New package: heroic-games-launcher-2.4.3 #40220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classabbyamp
added
electron 🤮
wiktorciurej
force-pushed
the
new_package/heroic-games-launcher
branch
from
d4841df
to
c4bc074
Compare
|
https://github.com/void-linux/void-packages/actions/runs/3353335290/jobs/5558484193#step:7:170 You are fetching precompiled binaries for glibc. |
wiktorciurej
force-pushed
the
new_package/heroic-games-launcher
branch
2 times, most recently
from
4443544
to
a422599
Compare
Yep, I just realised that and removed musl architectures completely. |
wiktorciurej
force-pushed
the
new_package/heroic-games-launcher
branch
from
a422599
to
e0b96b6
Compare
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
| @@ -0,0 +1,10 @@ | |||
| [Desktop Entry] | |||
| Name=Heroic Games Launcher | |||
| Exec=/usr/bin/heroic %U | |||
There was a problem hiding this comment.
Suggested change
| Exec=/usr/bin/heroic %U | |
| Exec=/opt/heroic/heroic %U |
| @@ -0,0 +1,57 @@ | |||
| # Template file for 'heroic-games-launcher' | |||
| pkgname=heroic-games-launcher | |||
| version=2.4.3 | |||
There was a problem hiding this comment.
Suggested change
| version=2.4.3 | |
| version=2.6.1 |
Comment on lines
+5
to
+6
| archs="x86_64 armv7l aarch64 ~*-musl" | ||
| wrksrc="HeroicGamesLauncher-${version}" |
There was a problem hiding this comment.
Suggested change
| archs="x86_64 armv7l aarch64 ~*-musl" | |
| wrksrc="HeroicGamesLauncher-${version}" | |
| archs="x86_64" |
| archs="x86_64 armv7l aarch64 ~*-musl" | ||
| wrksrc="HeroicGamesLauncher-${version}" | ||
| hostmakedepends="nodejs python3 yarn" | ||
| depends="alsa-lib gtk+3 nss python3" |
There was a problem hiding this comment.
Suggested change
| depends="alsa-lib gtk+3 nss python3" | |
| depends="fuse gawk" |
| license="GPL-3.0-or-later" | ||
| homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher" | ||
| distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz" | ||
| checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a |
There was a problem hiding this comment.
Suggested change
| checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a | |
| checksum=d312ae93a63029491bf23eb52074580e4a1830d030b70f9547fd9b187306f8aa |
Comment on lines
+19
to
+57
| case ${XBPS_TARGET_MACHINE} in | ||
| x86_64*) _arch=x64 ;; | ||
| aarch64*) _arch=arm64 ;; | ||
| armv7l*) _arch=armv7l ;; | ||
| *) broken="There is no electron package provided for selected architecture." ;; | ||
| esac | ||
|
|
||
| if ! [ ${_arch} == "x64" ]; then | ||
| nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl | ||
| /opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary" | ||
|
|
||
| skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl | ||
| /opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary" | ||
| fi | ||
|
|
||
| do_build() { | ||
| npm_config_arch=${_arch} npm_config_platform=linux yarn | ||
| npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch} | ||
| } | ||
|
|
||
| do_check() { | ||
| npm_config_arch=${_arch} yarn test | ||
| npm_config_arch=${_arch} yarn test:ci | ||
| } | ||
|
|
||
| do_install() { | ||
| vmkdir opt/heroic/ | ||
| if [ ${_arch} == "x64" ]; then | ||
| vcopy dist/linux-unpacked/* opt/heroic/ | ||
| else | ||
| vcopy dist/linux-${_arch}-unpacked/* opt/heroic/ | ||
| fi | ||
| vmkdir usr/bin/ | ||
| ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic | ||
| vmkdir usr/share/pixmaps/ | ||
| vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png | ||
| vmkdir usr/share/applications/ | ||
| vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/ | ||
| } |
There was a problem hiding this comment.
Suggested change
| case ${XBPS_TARGET_MACHINE} in | |
| x86_64*) _arch=x64 ;; | |
| aarch64*) _arch=arm64 ;; | |
| armv7l*) _arch=armv7l ;; | |
| *) broken="There is no electron package provided for selected architecture." ;; | |
| esac | |
| if ! [ ${_arch} == "x64" ]; then | |
| nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl | |
| /opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary" | |
| skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl | |
| /opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary" | |
| fi | |
| do_build() { | |
| npm_config_arch=${_arch} npm_config_platform=linux yarn | |
| npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch} | |
| } | |
| do_check() { | |
| npm_config_arch=${_arch} yarn test | |
| npm_config_arch=${_arch} yarn test:ci | |
| } | |
| do_install() { | |
| vmkdir opt/heroic/ | |
| if [ ${_arch} == "x64" ]; then | |
| vcopy dist/linux-unpacked/* opt/heroic/ | |
| else | |
| vcopy dist/linux-${_arch}-unpacked/* opt/heroic/ | |
| fi | |
| vmkdir usr/bin/ | |
| ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic | |
| vmkdir usr/share/pixmaps/ | |
| vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png | |
| vmkdir usr/share/applications/ | |
| vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/ | |
| } | |
| do_build() { | |
| yarn | |
| yarn dist:linux tar.xz | |
| } | |
| do_check() { | |
| yarn test | |
| yarn test:ci | |
| } | |
| do_install() { | |
| vmkdir opt/heroic | |
| vcopy dist/linux-unpacked/* opt/heroic | |
| vinstall public/icon.png 644 usr/share/pixmaps heroic.png | |
| vinstall ${FILESDIR}/heroic.desktop 644 usr/share/applications | |
| } |
|
The above suggestions are to update it to the latest version, reduce dependencies, simplify the process and make it build properly (the base code wasn't building in my machine). Compilation also failed when building for anything other than x86_64, so I've removed the other architectures. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package
Local build testing