Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgdal: update to 3.5.3 #40225

Merged
merged 8 commits into from Nov 5, 2022
Merged

libgdal: update to 3.5.3 #40225

merged 8 commits into from Nov 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2022

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl

Since python 2 packages are excluded in this update, issue #38229 is related.

Issues

None spotted at present time.

srcpkgs/libgdal/template Outdated Show resolved Hide resolved
srcpkgs/grass/template Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 1, 2022

CI builds indicate that OpenOrienteering-Mapper fails "sensor" test.

My attempts to "dig" into the issue itself brought more problems,
leading to the failing pre-build test on my side.

-- CMAKE_CXX_FLAGS: -DNDEBUG -fstack-clash-protection -D_FORTIFY_SOURCE=2 -O2 -mtune=generic   -I/usr/x86_64-linux-gnu/usr/include -fdebug-prefix-map=/builddir/mapper-0.9.5/build=. -Wall -Wpedantic -Wextra
-- CMAKE_CXX_FLAGS_NONE: 
-- CMAKE_C_FLAGS: -DNDEBUG -fstack-clash-protection -D_FORTIFY_SOURCE=2 -O2 -mtune=generic   -I/usr/x86_64-linux-gnu/usr/include -fdebug-prefix-map=/builddir/mapper-0.9.5/build=. -std=c99 -Wall -Wpedantic
-- CMAKE_C_FLAGS_NONE: 
-- Configuring done
CMake Error: AUTOMOC for target cove: Test run of "moc" executable "/usr/x86_64-linux-gnu/usr/lib/qt5/bin/moc" failed.
/usr/x86_64-linux-gnu/usr/lib/qt5/bin/moc -h

No such file or directory
CMake Generate step failed.  Build files cannot be regenerated correctly.
=> ERROR: OpenOrienteering-Mapper-0.9.5_2: do_configure: 'CFLAGS="-DNDEBUG ${CFLAGS/ -pipe / }" CXXFLAGS="-DNDEBUG ${CXXFLAGS/ -pipe / }" cmake ${cmake_args} ${configure_args} ${LIBS:+-DCMAKE_C_STANDARD_LIBRARIES="$LIBS"} ${LIBS:+-DCMAKE_CXX_STANDARD_LIBRARIES="$LIBS"} ${wrksrc}/${build_wrksrc}' exited with 1
=> ERROR:   in do_configure() at common/build-style/cmake.sh:75

chrooting into masterdir/usr/x86_64-linux-gnu and ensuring that the
"failing" binary executes correctly convince me that the problem might
be laying with my setup, although I am not sure what exactly is wrong.

Since I do not believe that I can solve it myself, I have disabled checks
for the time being to see what other issues the CI builder may show.

The "sensors" check has been disabled for now.

@ghost
Copy link
Author

ghost commented Nov 1, 2022

@classabbyamp, libgdal seems to refuse to build with armv6l (error: static assertion failed: OFF_T should be 64 bits !).

Comparing the source code of 3.0.4 and 3.5.2 (frmts/fits/fitsdataset.cpp), there was no such assertion in the old version.

Am I right to assume that this package and its reverse dependencies should be limited to aarch64*, i686*, and x86_64 since it cannot be built for 32-bit processors explicitly?

The same cannot be said of armv7l, but unrecognized -mtune target: generic ruined the building phase.

OFF_T assertion was fixed by fencing the particular library with XBPS_TARGET_WORDSIZE.

libgdal's setup.py script for python 3 bindings forcibly unset CC if its value contained >1 "word" and set gcc
which is not suited for crossbuildings, it seems. This issue was addressed in the new patch.

@ghost ghost changed the title libgdal: update to 3.5.2 libgdal: update to 3.5.3 Nov 1, 2022
Krul Ceter added 8 commits November 3, 2022 23:33
Additionally:

* fixed license to comply with xlint.
* replaced "http" with "https" in homepage.
"#unverified" near python_version has been removed due to confirmed
use of python 2.

According to REQUIREMENTS.html from the distributed tarball, python 3
support should be present in version >=7.8.0.

Updating this package to the latest release is challenging, meaning
that it will take more time to do that.
@ghost
Copy link
Author

ghost commented Nov 3, 2022

"Failed" builds may be safely ignored (they try to search for postgis-postgresql12-3.1.4_1 which does not exist anymore).

@ar-jan, would you be willing to test this package with its dependencies? I noticed that you have your own pull request, but too late for me, I suppose.

@ghost
Copy link
Author

ghost commented Nov 4, 2022

Tested every revbumped package briefly except for postgis-postgresql-13 and postgis-postgresql14.

@classabbyamp, is there anything else I have to do with suggested changes?

@the-maldridge
Copy link
Member

CI fails have been cleared, github is dumb though and hasn't updated the status icons here.

@classabbyamp classabbyamp merged commit 262c22e into void-linux:master Nov 5, 2022
@ghost ghost deleted the libgdal branch November 5, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants