taplo: update to 0.8.0 #40255
Merged
taplo: update to 0.8.0 #40255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinerea0
force-pushed
the
taplo
branch
3 times, most recently
from
d39f93d
to
c45c3a1
Compare
|
@q66 Does the change to the configure_args line look like it will allow taplo to be built on ppc? |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
This is still relevant and the issues regarding ppc have been addressed. |
paper42
reviewed
Feb 28, 2023
| build_wrksrc="crates/taplo-cli" | ||
| build_style=cargo | ||
| configure_args="--no-default-features --features lsp,native-tls" |
There was a problem hiding this comment.
could you leave a comment about why this is necessary?
There was a problem hiding this comment.
Sure, just added some comments in the latest push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
I've enabled a feature that should remove the arch restriction. If someone with ppc equipment could test, I'd be grateful.