Solaar: update to 1.1.8. #40318
Merged
Solaar: update to 1.1.8. #40318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find any usage of typing_extensions in the code, so I asked them in the PR that added it: pwr-Solaar/Solaar#1824 (comment) |
We should drop that dependency, it's a dependency of hid-parser which we don't package and only for Python 3.7. |
icp1994
force-pushed
the
Solaar
branch
3 times, most recently
from
38e0dbf
to
1cf20b2
Compare
paper42
reviewed
Nov 8, 2022
paper42
reviewed
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing