New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] xbps-src: default XBPS_MAKEJOBS to nproc
#40331
Conversation
21cee01
to
3422301
Compare
previously this defaulted to 1. In some rare cases, nproc is not desirable, but that can be easily overriden in the standard ways, etc/conf or -jN. For compatibility with other distros, it defaults to 1 when nproc is not available.
I kind of support this. I just wonder what the default should be; all cores, some cores, or specified cores. |
3422301
to
5855e89
Compare
Could we use the amount of cores divided by two? I support this also, but I feel like defaulting to all cores is a bit too much? |
I think |
nproc
nproc
I've seen plenty of historical recommendation for spawning twice as many jobs as CPUs with make, so defaulting to nproc seems reasonable. People with SMT CPUs will have the "right" value, and those without get a reduced "compromise" value. |
Most of the time I'm building stuff while doing other things on my machines. As I mentioned above I still feel like defaulting to all cores is a bit too much. On some of my machines multi tasking would no longer be possible. |
Compilation is I/O bound, which is why the usual recommendation is to use twice as many processes as you have CPUs. There's no need to try to get clever setting this. You can always override the parallelism if you find it too intensive, just as you have to override it now to get any parallelism. |
Was wondering the other day why this defaults to no parallelism (void newbie here). |
previously this defaulted to 1. In some rare cases, nproc is not desirable, but that can be easily overriden in the standard ways, etc/conf or -jN.
For compatibility with other distros, it defaults to 1 when nproc is not available.
Testing the changes