proj: update to 9.1.1 #40347

ar-jan · 2022-11-05T15:37:13Z

Testing the changes

I tested the changes in this PR: yes

Followup to #31687.

nezos · 2022-11-05T16:58:32Z

proj 7.2.1 is two major versions behind. I am running 9.1 without problems.

ar-jan · 2022-11-05T17:20:23Z

I tested everything with 7.2 and have been using that. When v8 came out there were some issues with v8 in combination with other packages as I recall. That may well have been solved but I'd rather get this in now since it's ready and tested.

The CI failures are unrelated (Python 3.11 packages not yet available).

srcpkgs/XyGrib/template

ghost · 2022-11-08T15:29:40Z

@ar-jan, I have updated proj to 9.1.0 in the forked repository (https://github.com/kruceter/void-packages/tree/proj).

In my attempts to revbump reverse dependencies I could fix some issues related
to the new API of PROJ (>=8.0.0) and tested them briefly.

I hope my changes will prove to be useful for you in some way.

ar-jan · 2022-11-08T16:08:55Z

Ah great. I've also been testing proj 9.1.0 and I thought there's a few more things to solve. Here's my notes:

grass: v7.6 still uses proj_api.h, but the build does succeed. [Do you know if it functions correctly without proj4 api?]
XyGrib: can be patched like New lib proj api opengribs/XyGrib#289 [I see you used that].
merkaartor: with DACCEPT_USE_OF_DEPRECATED_PROJ_API_H removed, build still failed for me. Did it build correctly for you?
vtk: current version fails due to proj_api.h, but it can be upgraded to >= 9.1.0 to fix.

ghost · 2022-11-08T17:00:50Z

grass: v7.6 still uses proj_api.h, but the build does succeed. [Do you know if it functions correctly without proj4 api?]

It should work. configure has the following lines confirming this:

# PROJ version check: if proj.h exists, it must be proj 5+

ac_save_cppflags="$CPPFLAGS"
CPPFLAGS="$PROJINC $CPPFLAGS"
for ac_hdr in proj.h
do
ac_safe=`echo "$ac_hdr" | sed 'y%./+-%__p_%'`
echo $ac_n "checking for $ac_hdr""... $ac_c" 1>&6
echo "configure:5727: checking for $ac_hdr" >&5

cat > conftest.$ac_ext <<EOF
#line 5730 "configure"
#include "confdefs.h"
#include <$ac_hdr>
EOF

UPD: I could not open it due to "missing GUI" (possibly refers to wxPython). I will look into it on my side.

merkaartor: with DACCEPT_USE_OF_DEPRECATED_PROJ_API_H removed, build still failed for me. Did it build correctly for you?

It did for me with proj 9.0.1.

vtk: current version fails due to proj_api.h, but it can be upgraded to >= 9.1.0 to fix.

I am at fault for overlooking it. I will update it on my side to see whether it works or not.

ar-jan · 2022-11-08T17:32:46Z

UPD: I could not open it due to "missing GUI" (possibly refers to wxPython). I will look into it on my side.

Iirc had to start explicitly using something like GRASS_PYTHON=python2. Could also update to v7.8, done that in previous PR.

ghost · 2022-11-08T17:39:47Z

Iirc had to start explicitly using something like GRASS_PYTHON=python2. Could also update to v7.8, done that in previous PR.

Still the same outcome. I will try to update it 7.8.7 and see how it turns out.

nezos · 2022-11-08T23:15:42Z

Grass GUI never worked, in older version on Void, I had to hack the startup script. Now that I use v8.2, it doesn't start also but I don't need it as I use QGIS. If I try to start the grass GUI I get:

TypeError: ToolBar.AddTool(): arguments did not match any overloaded call:

The problem refers to the wxPython package, it's an old issue:

OSGeo/grass#2019 (comment)

Updating also grass would pave the way for having qgis as a package.

Hope this helps

ar-jan · 2022-11-08T23:29:48Z

Yeah, grass was the reason my previous PR #31687 didn't get merged, and I spent a long time trying things with wxPython, but I did actually get it to work with python2 and v7.8. Also grass is optional for QGIS, I have a branch ready for QGIS 3.28 which just doesn't include grass.

ghost · 2022-11-09T01:43:38Z

I managed to build grass 7.8.7 with proj 9.1.0.

Its GUI started without any surprises; and what is more important, it works with python 3 (at least I swapped out everything related to python 2). That was my original purpose for picking this package, so I am content.

vtk 9.1.0 is not tested yet; it is quite a large piece of software to build on my machine.

@ar-jan, I have pushed all changes to the "proj" branch in kruceter/void-packages, so you can use them however you wish.

@nezos

Grass GUI never worked

Thank you for mentioning this. I was a little afraid to think that I broke grass by tampering with it in a related pull request.

As for versions starting from 8, I had learned of incompatibility with the current wxPython4 through trial and error; this includes that issue you have referred to.

Unless wxPython4 is updated, nothing can be done about upgrading to grass 8.

nezos · 2022-11-09T13:45:09Z

Also grass is optional for QGIS, I have a branch ready for QGIS 3.28 which just doesn't include grass.
My opinion is that in such software you need all the tools possible to handle different kinds of data. QGIS still relies on tools provided by GRASS to perform many tasks.

@kruceter I see though in the grass template you have in your fork that you still rely on python2.

I confirm also that grass and QGIS 3.28 builds with proj 9.1.

ghost · 2022-11-09T15:53:08Z

@kruceter I see though in the grass template you have in your fork that you still rely on python2.

https://github.com/kruceter/void-packages/commit/f494f414a06f5c1855cb2fca12e3c3e5b82cea4a#diff-ebae98cb097fc36b8a6f7cc1d8ca2b9a319bcb740ecf0e2cfc9d995c07d4ebf2

ar-jan · 2022-11-09T17:26:44Z

I have pushed all changes to the "proj" branch in kruceter/void-packages, so you can use them however you wish.

Thanks @kruceter. I've cherry-picked your commits for grass, XyGrib, and OpenOrienteering-Mapper. Now building 9.1 &co again.

ar-jan · 2022-11-10T00:06:17Z

As discussed on irc, vtk will have to be upgraded first separately because it provides shlibs which are used by other packages: #40423.

ar-jan · 2022-12-03T23:21:59Z

Oh, proj-9.1.1 was just released, I'll update to that.

srcpkgs/OpenOrienteering-Mapper/template

srcpkgs/osm2pgsql/template

ar-jan · 2023-01-12T20:29:36Z

I think this is ready, I've been running proj-9.1.1 for over a month.

Only sore point is grass. But afaict the version of grass that's currently packaged is more broken than the update to 7.8.7 included here, because here only the gui is broken while text mode works.

Or maybe grass could be removed? I wonder if anyone is even using it on Void given that it seems to be broken to several of us.

ar-jan · 2023-01-12T23:30:24Z

@kruceter Would you care to see if you can get it to work? I gathered these from the error messages involved. I didn't get it working but iirc I stopped before trying all of them combined.

Need to backport fixes to wxPython 4.0.7 with Python 3.8+
Via OSGeo/grass#1971 (comment):
https://src.fedoraproject.org/rpms/python-wxpython4/c/f55a17c2d3b336c82fb44f7816ec63219847f4cc?branch=rawhide:
https://github.com/wxWidgets/Phoenix/commit/9096426603272672d9a676e8bcdcadf0a1cfa1a2.patch [from https://github.com/wxWidgets/Phoenix/pull/1533 Add index...]
https://github.com/wxWidgets/Phoenix/commit/3eb9eb32dc3285435039f6c420c398665372a1ad.patch [from https://github.com/wxWidgets/Phoenix/pull/2005 ScrolledWindow.SetScrollbars]
https://github.com/wxWidgets/Phoenix/commit/0d449626d6d298ad96ebd1d514d0e42833bce470.patch [from https://github.com/wxWidgets/Phoenix/pull/2026 integer division]

ghost · 2023-01-13T01:00:40Z

Applied proposed patches and rebuilt wxPython4 with grass. The outcome is same.

ghost · 2023-01-14T02:58:20Z

There is no way to disable GUI using build arguments, their old manual misled me.

Rebase and apply this patch (and change version in the commit message too):

0001-fixup-grass-update-to-7.8.7-rebuild-for-proj-9.1.txt

There is nothing we can do about broken gui at present time, so leave it be.

If GUI does not work, grass falls back to the text mode. We can live with it at least until wxPython is updated. If you are interested in enforcing the text mode, add the following block to the template:

post_install() {
	# This package is broken with wxPython4 (<=4.0.7),
	# hence the GUI is compulsorily disabled.
	vsed -i "${DESTDIR}/usr/bin/grass" -e "s/\(default_gui =\).*/\1 \"text\"/"
}

Aside from grass I think this pull request can be merged.

ar-jan · 2023-01-15T12:00:48Z

I wonder if it wouldn't be cleaner to drop the grass package for now, instead of patching it to be text-only. Any thoughts, @alexjarosch @classabbyamp?

nezos · 2023-01-16T09:29:03Z

I wonder if it wouldn't be cleaner to drop the grass package for now, instead of patching it to be text-only. Any thoughts, @alexjarosch @classabbyamp?

If you drop GRASS then you will lose the functionality also from the QGIS Toolbox. I have read that GRASS8 works with the latest QGIS (since v3.24). Even if as a standalone it does not work, the toolbox options are handy.

classabbyamp · 2023-01-16T09:34:32Z

removing grass is not the right way. i think the right way would be to update wxpython but that's a bit of scope creep :)

better to just patch it for now

alexjarosch · 2023-01-16T09:50:33Z

I agree with the two posts above from @classabbyamp and @nezos . I think we don't want to loose the functionality in QGIS as well as GRASS. Updating wxpython is really another scope as pointed out above, so I second the opinion tp better just patch it for now.

The current release does not support the new API of PROJ (>=8.0.0); included patch aims to solve the issue. Conditional make_build_args prevents crossbuilding with failing ninja ("unknown target LINK=${XBPS_CROSS_TRIPLET}-c++"). I suspect that this approach is a relique of the past and therefore is removed from the template. No other issues did arise due to this change.

ar-jan · 2023-01-22T15:52:12Z

OK, agree having the grass toolbox algorithms in QGIS will be useful. I've briefly tested a new QGIS build with Grass 8.2.1 and looks good.

@kruceter I've used your patch but also updated to grass-8.2.1 which was just released, so the patches could be dropped again.

ghost · 2023-01-23T06:36:21Z

I've used your patch but also updated to grass-8.2.1 which was just released, so the patches could be dropped again.

No problem at all. This would be for the best.

ar-jan changed the title ~~Update proj to 7.2.1~~ proj: update to 7.2.1 Nov 5, 2022

classabbyamp reviewed Nov 5, 2022

View reviewed changes

srcpkgs/XyGrib/template Outdated Show resolved Hide resolved

ar-jan force-pushed the proj-721 branch 2 times, most recently from 386fff1 to f986851 Compare November 8, 2022 13:24

ar-jan force-pushed the proj-721 branch from f986851 to 398fd22 Compare November 8, 2022 17:00

ar-jan force-pushed the proj-721 branch from 398fd22 to 13c884c Compare November 15, 2022 16:57

ar-jan changed the title ~~proj: update to 7.2.1~~ proj: update to 9.1.0 Nov 15, 2022

ar-jan marked this pull request as draft November 15, 2022 16:58

ar-jan force-pushed the proj-721 branch 3 times, most recently from fa3d286 to 6e016c8 Compare November 20, 2022 18:41

ar-jan force-pushed the proj-721 branch 2 times, most recently from e0766a6 to f8e13ea Compare December 3, 2022 23:17

ar-jan marked this pull request as ready for review December 3, 2022 23:18

ar-jan force-pushed the proj-721 branch from f8e13ea to ff85cdd Compare December 4, 2022 13:43

classabbyamp reviewed Dec 4, 2022

View reviewed changes

srcpkgs/OpenOrienteering-Mapper/template Outdated Show resolved Hide resolved

ar-jan force-pushed the proj-721 branch from 0f7814e to db740ea Compare December 4, 2022 23:02

ghost reviewed Jan 9, 2023

View reviewed changes

srcpkgs/osm2pgsql/template Outdated Show resolved Hide resolved

ar-jan force-pushed the proj-721 branch from db740ea to 1b08cd9 Compare January 11, 2023 21:38

ar-jan and others added 12 commits January 22, 2023 14:50

proj: update to 9.1.1.

3a4756c

libgdal: rebuild for proj 9.1

3db6f78

libspatialite: rebuild for proj 9.1

7833a17

postgis-postgresql14: rebuild for proj 9.1

4813088

postgis-postgresql13: rebuild for proj 9.1

f41f5ef

merkaartor: rebuild for proj 9.1

41593b9

sumo: rebuild for proj 9.1

0e01bed

osm2pgsql: rebuild for proj 9.1

59fb7fa

grass: update to 8.2.1; disable gui; rebuild for proj 9.1

52193cc

OpenOrienteering-Mapper: rebuild for proj 9.1

65636ea

vtk: rebuild for proj 9.1

37b5fd3

ar-jan force-pushed the proj-721 branch from 1b08cd9 to 37b5fd3 Compare January 22, 2023 15:45

Johnnynator merged commit 2586316 into void-linux:master Jan 22, 2023

ar-jan mentioned this pull request Jul 28, 2023

New package: QGIS #41812

Merged

ar-jan deleted the proj-721 branch September 9, 2023 22:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

proj: update to 9.1.1 #40347

proj: update to 9.1.1 #40347

ar-jan commented Nov 5, 2022 •

edited

Loading

nezos commented Nov 5, 2022

ar-jan commented Nov 5, 2022

ghost commented Nov 8, 2022

ar-jan commented Nov 8, 2022

ghost commented Nov 8, 2022 •

edited by ghost

Loading

ar-jan commented Nov 8, 2022

ghost commented Nov 8, 2022 •

edited by ghost

Loading

nezos commented Nov 8, 2022 •

edited

Loading

ar-jan commented Nov 8, 2022

ghost commented Nov 9, 2022 •

edited by ghost

Loading

nezos commented Nov 9, 2022

ghost commented Nov 9, 2022

ar-jan commented Nov 9, 2022

ar-jan commented Nov 10, 2022 •

edited

Loading

ar-jan commented Dec 3, 2022 •

edited

Loading

ar-jan commented Jan 12, 2023

ar-jan commented Jan 12, 2023

ghost commented Jan 13, 2023

ghost commented Jan 14, 2023 •

edited by ghost

Loading

ar-jan commented Jan 15, 2023

nezos commented Jan 16, 2023

classabbyamp commented Jan 16, 2023

alexjarosch commented Jan 16, 2023

ar-jan commented Jan 22, 2023

ghost commented Jan 23, 2023

proj: update to 9.1.1 #40347

proj: update to 9.1.1 #40347

Conversation

ar-jan commented Nov 5, 2022 • edited Loading

Testing the changes

nezos commented Nov 5, 2022

ar-jan commented Nov 5, 2022

ghost commented Nov 8, 2022

ar-jan commented Nov 8, 2022

ghost commented Nov 8, 2022 • edited by ghost Loading

ar-jan commented Nov 8, 2022

ghost commented Nov 8, 2022 • edited by ghost Loading

nezos commented Nov 8, 2022 • edited Loading

ar-jan commented Nov 8, 2022

ghost commented Nov 9, 2022 • edited by ghost Loading

nezos commented Nov 9, 2022

ghost commented Nov 9, 2022

ar-jan commented Nov 9, 2022

ar-jan commented Nov 10, 2022 • edited Loading

ar-jan commented Dec 3, 2022 • edited Loading

ar-jan commented Jan 12, 2023

ar-jan commented Jan 12, 2023

ghost commented Jan 13, 2023

ghost commented Jan 14, 2023 • edited by ghost Loading

ar-jan commented Jan 15, 2023

nezos commented Jan 16, 2023

classabbyamp commented Jan 16, 2023

alexjarosch commented Jan 16, 2023

ar-jan commented Jan 22, 2023

ghost commented Jan 23, 2023

ar-jan commented Nov 5, 2022 •

edited

Loading

ghost commented Nov 8, 2022 •

edited by ghost

Loading

ghost commented Nov 8, 2022 •

edited by ghost

Loading

nezos commented Nov 8, 2022 •

edited

Loading

ghost commented Nov 9, 2022 •

edited by ghost

Loading

ar-jan commented Nov 10, 2022 •

edited

Loading

ar-jan commented Dec 3, 2022 •

edited

Loading

ghost commented Jan 14, 2023 •

edited by ghost

Loading