Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnma: update to 1.10.4; network-manager-applet: update to 1.30.0 #40388

Merged
merged 2 commits into from Nov 17, 2022

Conversation

cinerea0
Copy link
Contributor

@cinerea0 cinerea0 commented Nov 8, 2022

Testing the changes

  • I tested the changes in this PR: YES

@paper42
Copy link
Member

paper42 commented Nov 8, 2022

libgnome-keyring is deprecated, can we remove the build dependency?

@cinerea0
Copy link
Contributor Author

cinerea0 commented Nov 9, 2022

I'm currently testing the latest push with libgnome-keyring removed, and everything seems to be working properly.

srcpkgs/libnma/template Outdated Show resolved Hide resolved
srcpkgs/network-manager-applet/template Outdated Show resolved Hide resolved
srcpkgs/network-manager-applet/template Outdated Show resolved Hide resolved
srcpkgs/libnma/template Outdated Show resolved Hide resolved
@cinerea0
Copy link
Contributor Author

@paper42 I've made the suggested changes. I'm a bit confused as to the utility of directly placing the package name in the distfiles link for these packages, since the GNOME_SITE shortener makes it pretty obscured regardless.

@paper42
Copy link
Member

paper42 commented Nov 17, 2022

@paper42 I've made the suggested changes. I'm a bit confused as to the utility of directly placing the package name in the distfiles link for these packages, since the GNOME_SITE shortener makes it pretty obscured regardless.

$pkgname doesn't really make sense, in many cases it's not shorter and if the package is renamed, we still want to use the same sources as before the rename: leahneukirchen/xtools#271

@paper42 paper42 merged commit 7e47d7e into void-linux:master Nov 17, 2022
@cinerea0 cinerea0 deleted the nma branch November 18, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants