Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/hooks/do-extract/00-distfiles.sh: support deb files #40405

Merged
merged 21 commits into from
Nov 19, 2022
Merged

common/hooks/do-extract/00-distfiles.sh: support deb files #40405

merged 21 commits into from
Nov 19, 2022

Conversation

classabbyamp
Copy link
Member

@classabbyamp classabbyamp commented Nov 9, 2022 •
edited
Loading

Testing the changes

  • I tested the changes in this PR: YES (tested extraction/installation works for all packages with debs, packages generated are sane and are the same as before, except where deliberately changed)

@classabbyamp classabbyamp added the xbps-src xbps-src related label Nov 9, 2022
@classabbyamp classabbyamp force-pushed the deb-extract branch 3 times, most recently from 85b53da to f75fbb8 Compare November 10, 2022 09:23
@classabbyamp
Copy link
Member Author

had to update yandex-disk due to the old version's distfile no longer existing upstream. seems to work from my basic testing but I don't have an account

@classabbyamp classabbyamp marked this pull request as ready for review November 11, 2022 08:18
ahesford
ahesford approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not thrilled about making it easier to make packages from debs, but it clearly addresses a need.

@classabbyamp
Copy link
Member Author

yeah I don't want to encourage debs, but the manual way is gross and inconsistent and increasing support for it could maybe make xdeb less attractive of an option for out-of-tree trees

@classabbyamp classabbyamp merged commit 6e3344e into void-linux:master Nov 19, 2022
@classabbyamp classabbyamp deleted the deb-extract branch November 19, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgn sgn sgn left review comments

@ahesford ahesford ahesford approved these changes

Assignees
No one assigned
Labels
xbps-src xbps-src related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@classabbyamp @sgn @ahesford