Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spice: update to 0.15.1. #40486

Merged
merged 1 commit into from Nov 18, 2022
Merged

spice: update to 0.15.1. #40486

merged 1 commit into from Nov 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2022

Updated, and removed python 2 dependency (#38229).

Testing the changes

  • I tested the changes in this PR: briefly
    I didn't do much testing other than making sure that the tests pass and that qemu-system-x86_64 doesn't crash.
    The python scripts as far as I can tell are only involved in unit testing; moreover, upstream uses python3 in their CI.

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64 (crossbuild)

@ghost
Copy link

ghost commented Nov 14, 2022

Works for me on x86_64-musl. GCC 12 was used for building this package.

I use qemu from time to time for harmful operating systems with various architectures and can confirm that in my use case qemu-system-i386 and qemu-system-x86_64 do not crash and do not produce unexpected behavior.

spice.txt

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change sed to vsed

@ghost
Copy link
Author

ghost commented Nov 15, 2022

ERROR: spice-0.15.0_1: vsed: regex "s/armv6hl/arm/g" didn't change file "configure"

It appears that this patch became obsolete at some point so I removed it altogether.

srcpkgs/spice/template Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 17, 2022

@paper42, I've applied your suggestions. I usually try to limit commits to minimal changes required to satisfy the intent of a commit. In future, when changing a template, should I try to improve it as much as I could in one go?

@paper42
Copy link
Member

paper42 commented Nov 18, 2022

@paper42, I've applied your suggestions. I usually try to limit commits to minimal changes required to satisfy the intent of a commit. In future, when changing a template, should I try to improve it as much as I could in one go?

Yes, if you feel like it's not clear enough what you are doing, feel free to mention it in the commit message body.

@paper42 paper42 merged commit ab41765 into void-linux:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant