Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: omegat-4.3.3 #40500

Closed
wants to merge 3 commits into from
Closed

Conversation

sirkhancision
Copy link
Contributor

Hello, this is my first contribution to void-packages, so forgive me if there's anything weird. :)

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures:
    • x86_64-musl
    • armv6l-glibc
    • armv6l-musl
    • i686-glibc

@classabbyamp classabbyamp added the new-package This PR adds a new package label Nov 13, 2022
srcpkgs/omegat/template Outdated Show resolved Hide resolved
srcpkgs/omegat/template Show resolved Hide resolved
srcpkgs/omegat/template Outdated Show resolved Hide resolved
srcpkgs/omegat/template Outdated Show resolved Hide resolved
srcpkgs/omegat/template Outdated Show resolved Hide resolved
srcpkgs/omegat/template Outdated Show resolved Hide resolved
srcpkgs/omegat/template Outdated Show resolved Hide resolved
srcpkgs/omegat/template Outdated Show resolved Hide resolved
@sirkhancision
Copy link
Contributor Author

Just committed those changes, also changing the docs that are copied and making the necessary changes to build the package.
I did not use the SOURCEFORGE_SITE variable in distfiles because it was defaulting to downloading the Nightly build.

@sirkhancision
Copy link
Contributor Author

Put the stuff related to documentation in post_install, also made it so that it only copies the doc files and directories themselves instead of the parent directory.

btw I don't know why the CI test failed in the "fix-permissions" step previously, I ran ./xbps-src -Q pkg omegat locally and everything went smoothly.

srcpkgs/omegat/template Show resolved Hide resolved
srcpkgs/omegat/template Outdated Show resolved Hide resolved

post_install() {
vmkdir usr/share/doc/omegat
vcopy "build/install/OmegaT/docs/*" usr/share/doc/omegat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcopy "build/install/OmegaT/docs/*" usr/share/doc/omegat
vcopy "build/install/OmegaT/docs/*" usr/share/doc/omegat
chmod -R 644 ${DESTDIR}/usr/share/doc/omegat

this should fix the build error

Copy link
Contributor Author

@sirkhancision sirkhancision Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using vcopy to copy the entire directory, I'm now using vdoc on the actual documentation files that come specifically with the local build. Should fix it, indeed.
That is, of course, if the vcopy on the other directories don't create a new problem :p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying the directories with vcopy also result in the permission build error, and when trying to chmod -R 644, it gives me chmod: cannot access '{path to file}': Permission denied.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 7, 2023
@github-actions github-actions bot closed this Mar 22, 2023
@sirkhancision sirkhancision deleted the omegat branch June 1, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants