New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: pdfarranger-1.10.1 #40541
Conversation
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
This is ready to be merged. |
# tests require involved xvfb setup | ||
make_check=no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would make_check_pre="xvfb-run"
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, I tried it and added xvfb-run
in the checkdepends but it didn't work:
=> pdfarranger-1.9.2_1: running do_check ...
============================= test session starts ==============================
platform linux -- Python 3.11.2, pytest-7.2.1, pluggy-1.0.0
rootdir: /builddir/pdfarranger-1.9.2
collected 0 items
============================ no tests ran in 0.03s =============================
=> ERROR: pdfarranger-1.9.2_1: do_check: 'PYTHONPATH="$(cd build/lib* && pwd)" ${make_check_pre} python3 -m pytest ${testjobs} ${make_check_args} ${make_check_target}' exited with 5
=> ERROR: in do_check() at common/build-style/python3-module.sh:15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggests there are no tests in the tarball. If that's true, please change the comment on 'make_check=no` to note that there are no tests in the source distribution.
The template (https://github.com/void-linux/void-packages/blob/9bc0131abd405075b3e1ade6c95a2498c9fd7f06/srcpkgs/pdfarranger/template) works fine. Was able to successfully build and subsequently install the resulting xbps package. The application runs fine. |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
closes #40138
Testing the changes
New package
Local build testing