libplacebo: update to 5.229.2 #40807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmnmnnmnmm
force-pushed
the
libplacebo
branch
2 times, most recently
from
78721f2
to
eb0b561
Compare
mmnmnnmnmm
force-pushed
the
libplacebo
branch
from
eb0b561
to
55408fd
Compare
mmnmnnmnmm
force-pushed
the
libplacebo
branch
from
55408fd
to
62b9a2b
Compare
mmnmnnmnmm
changed the title
triallax
reviewed
Feb 26, 2023
| hostmakedepends="pkg-config python3-Mako Vulkan-Headers" | ||
| makedepends="shaderc Vulkan-Headers vulkan-loader $(vopt_if lcms lcms2-devel) | ||
| $(vopt_if opengl libepoxy-devel)" | ||
| -Dlcms=$(vopt_if lcms en dis)abled -Ddemos=false -Dtests=true" |
There was a problem hiding this comment.
Tests should only be enabled when checks are enabled:
Suggested change
| -Dlcms=$(vopt_if lcms en dis)abled -Ddemos=false -Dtests=true" | |
| -Dlcms=$(vopt_if lcms en dis)abled -Ddemos=false" |
| short_desc="Reusable library for GPU-accelerated video/image rendering" | ||
| maintainer="Enrico Belleri <idesmi@protonmail.com>" | ||
| license="LGPL-2.1-or-later" | ||
| homepage="https://code.videolan.org/videolan/libplacebo" | ||
| distfiles="https://code.videolan.org/videolan/libplacebo/-/archive/v${version}/libplacebo-v${version}.tar.gz" | ||
| checksum=7b3c857934ee3d30f743e43d7f0606e10950806661ea0ea385f8a1f06cbab854 | ||
| checksum=a42035c69e4a6373cb9856cc0c5736f24af4485006f3b29605ddffba377264db | ||
|
|
||
| if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then | ||
| makedepends+=" libatomic-devel" | ||
| LDFLAGS+=" -latomic" | ||
| fi |
There was a problem hiding this comment.
Suggested change
| fi | |
| fi | |
| if [ -n "$XBPS_CHECK_PKGS" ]; then | |
| configure_args+=" -Dtests=true" | |
| else | |
| configure_args+=" -Dtests=false" | |
| fi |
(I like to add both branches just in case the default value of the option changes)
Comment on lines
+15
to
+19
| make_check=no # Jinja2 raises exceptions | ||
|
|
||
| do_check() { | ||
| nosetests | ||
| } |
There was a problem hiding this comment.
Suggested change
| make_check=no # Jinja2 raises exceptions | |
| do_check() { | |
| nosetests | |
| } | |
| make_check=no # Jinja2 raises exceptions | |
| do_check() { | |
| nosetests | |
| } |
|
Tested PR (also not with Vulkan but OpenGL) and can confirm it works. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unable to test Vulkan output, but OpenGL works fine.
Testing the changes
Local build testing