Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widelands: update to 1.1. #40819

Closed
wants to merge 2 commits into from
Closed

widelands: update to 1.1. #40819

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2022

cc: @travankor

Related to #39083.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64
    • armv6l-musl (cross)

srcpkgs/widelands/template Outdated Show resolved Hide resolved
+#if (ULONG_MAX == 0xffffffffffffffff)
#define PRIuS "lu"
#else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have a patch that highlight 32bit platform, too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not marking as resolved yet. I hope #if (ULONG_MAX == 0xffffffff) is the right directive for 32 bit platforms.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it can be simple than that, it's zu

Krul Ceter and others added 2 commits December 2, 2022 23:27
boost is deprecated and removed upstream.

Following the deprecation procedure upstream now needs asio.
@sgn sgn closed this Dec 3, 2022
@sgn
Copy link
Member

sgn commented Dec 3, 2022

Merged. 840d14a

@ghost ghost deleted the widelands branch December 3, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant