Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3: add few missing depends #41046

Closed
wants to merge 3 commits into from
Closed

python3: add few missing depends #41046

wants to merge 3 commits into from

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Dec 12, 2022

@ahesford Forgot to explicitly add a couple of depends.

ahesford
ahesford requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the modifications noted below, please rearrange the commits so that python3-notebook_shim appears in the history before the jupyterlab commit that adds the dependency.

srcpkgs/python3-jupyter_console/template Outdated Show resolved Hide resolved
srcpkgs/jupyter-notebook-shim/template Outdated Show resolved Hide resolved
@dkwo dkwo force-pushed the pytfix branch 2 times, most recently from 7579ce3 to 77c4d56 Compare December 12, 2022 21:54
@dkwo dkwo requested a review from ahesford December 12, 2022 21:55
@dkwo dkwo mentioned this pull request Dec 12, 2022
Closed
@dkwo
Copy link
Contributor Author

dkwo commented Dec 12, 2022

@tornaria @ahesford I believe this is the right way to fix it.

@ahesford ahesford closed this in ac8728d Dec 13, 2022
zen0bit pushed a commit to oSoWoSo/VUR that referenced this pull request Dec 13, 2022
@dkwo @zen0bit
jupyterlab: add missing dep
4c203e1 
Closes: void-linux#41046 [via git-merge-pr]
@dkwo dkwo deleted the pytfix branch February 13, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahesford ahesford ahesford requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkwo @ahesford