Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox-ose: update to 7.0.4. #41109

Closed
wants to merge 8 commits into from
Closed

Conversation

gc-user
Copy link

@gc-user gc-user commented Dec 15, 2022

Testing the changes

  • I tested the changes in this PR: The packages xbps files for host installation were tested, the ones for installation on a guest not.

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

My first commit / PR ever.
This update was done by modifying the respective files of v6.1.36 until the build process went through all the way. Resulting xbps files installed fine and seem to run fine, as well. The "guest" packages were not tested!

VBoxSDL has been removed from line 77 because it caused the "install" section of the build process to fail. Comparing v6.1.36 with a v7.0.4 package from the virtualbox website showed that, apparently, there is no VBoxSDL.so file anymore in v7.0.4. So, I deleted that entry and the build process went through. As stated, the program, installed using the xbps files resulting from these changes to the files from v6.1.36, seem to work as expected.
virtualbox-ose: update to 7.0.4.
My first commit / PR ever.
This update was done by modifying the respective files of v6.1.36 until the build process went through all the way. Resulting xbps files installed fine and seem to run fine, as well. The "guest" packages were not tested!

VBoxSDL has been removed from line 77 because it caused the "install" section of the build process to fail. Comparing v6.1.36 with a v7.0.4 package from the virtualbox website showed that, apparently, there is no VBoxSDL.so file anymore in v7.0.4. So, I deleted that entry and the build process went through. As stated, the program, installed using the xbps files resulting from these changes to the files from v6.1.36, seem to work as expected.
No code change, only title changed because apparently one can't change in in an existing commit, and the "wrong" title results in the commit not being accepted in PR.
@sgn
Copy link
Member

sgn commented Dec 15, 2022

Please check this PR instead #41111

@gc-user
Copy link
Author

gc-user commented Dec 15, 2022

Thanks!
Github won't let me do edits I expected I would be able to do... :-)

@paper42
Copy link
Member

paper42 commented Dec 15, 2022

you will have to use the git cli

@gc-user
Copy link
Author

gc-user commented Dec 15, 2022

Yeah, that's what I figured after doing some internet search...
Me using git cli will probably not happen very soon... :-)
Now I hopefully know how to label titles correctly.

@sgn made a much better PR anyway, including qt6 and adding two extra patches I could never have come up with..

@gc-user gc-user closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants