New package: Tuner-1.5.1

[MechDR]

Testing the changes

• I tested the changes in this PR: YES

[MechDR]

Any suggestions on how to fix these issues?

[oreo639]

glib needs to be in hostmakedepends (as well as makedepends).
hostmakedepends is for packages that will be installed for the build-machine's architecture and makedepends is for packages that will be installed for the target's architecture. Those will be the same when native compiling and different when cross-compiling. (in the case of glib, you need both)

Also subject does not follow CONTRIBUTING.md guildelines, your commit message doesn't follow the guidelines. (it should be New package: Tuner-1.5.1)

You can fix the commit message using git commit --amend

https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md

[MechDR]

@oreo639 Is this OK?

[MechDR]

OK, everything failed, what's wrong now...

[paper42]

OK, everything failed, what's wrong now...

exactly what it's telling you

Your branches is based on too old copy.
Please rebase to newest copy.

[paper42]

also, this PR should contain one commit, squash them please

[MechDR]

Let's see...

[MechDR]

I synced my fork with master, it still reports the same error...

[Chocimier]

glib-compile-resources is in glib-devel so you need to add that to hostmakedepends.

You need to rebase and force push the submitted branch, not master.

[oreo639]

Also, I recommend you use the command line. There are a lot of thing you cannot do from the web ui.

I recommend you read:
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md

You can fix the commit history with the following:

git clone https://github.com/MechDR/void-packages/ -b tuner
cd void-packages
git remote add upstream https://github.com/void-linux/void-packages.git
git reset --soft HEAD~2
git commit --amend
git push -f
git pull --rebase upstream master
git push -f

The commit needs to be named New package: Tuner-1.5.1.

In the future, do git add <file>, git commit --amend, git push -f

[MechDR]

@oreo639 I do appreciate the effort and the mini command tutorial you did, but I'm stuck...

git pull --rebase upstream master

error: cannot pull with rebase: You have unstaged changes.
error: please commit or stash them.

Now what...

[paper42]

You have changes that you didn't commit, run git diff or git status to see them and do something about them - either remove them with git restore, put them away for a while with git stash or commit them with git add and git commit

[paper42]

I am against including a new package that uses libsoup2, especially geocode-glib-libsoup2, we should be trying to slowly get rid of those packages.

[MechDR]

Things should be resolved in next versions, as the dev seems to be on board about dropping support for user location all together in the new milestone version 1.6.

louis77/tuner#106

So, this would only be a temporary solution, just to get Tuner in the src collection.

Sorry for the delay, I don't have a lot of free time currently, I'll try and get this done next week or so.

PS: I'm sorry if I sounded kinda harsh with my previous comments, it's personal real life problems, nothing to do with anyone I replied to, people have been more than helpful here.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.