Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: ipsvd, socklog-ucspi #41321

Merged
merged 2 commits into from Jan 2, 2023
Merged

New packages: ipsvd, socklog-ucspi #41321

merged 2 commits into from Jan 2, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 28, 2022

cc: @leahneukirchen (socklog's maintainer)

Closes #41300.

socklog-ucspi

Testing the changes

  • I tested the changes in this PR: briefly

ipsvd

The build method is not much different from socklog (the same author).

Testing the changes

  • I tested the changes in this PR: briefly

New package

@leahneukirchen
Copy link
Member

Packaging ipsvd is fine, I'd not change the depends for socklog as this is a mode that's rarely used.

@leahneukirchen
Copy link
Member

You could make a socklog-remote or so package that depends on socklog and ipsvd and provides a service.

@ghost ghost changed the title socklog: depend on ipsvd for ucspi-tcp service New packages: ipsvd, socklog-ucspi Dec 28, 2022
@sbromberger
Copy link
Contributor

sbromberger commented Dec 29, 2022

Packaging ipsvd is fine, I'd not change the depends for socklog as this is a mode that's rarely used.

The problem is that the current installation of socklog is broken precisely because it assumes tcpsvd is available, and it's not. As I see it, the options are either

  1. package ipsvd and make it a dependency,
  2. change socklog dependency to include djb's ucspi-tcp package (might also need tcp6) and change the syntax in the socklog-ucspi run file,
  3. disable / remove socklog-ucspi, and/or
  4. modify the manpage to clarify that it won't work unless you install and configure a valid tcpserver implementation separate from the official manpage guidelines.

@ghost
Copy link
Author

ghost commented Dec 29, 2022

change socklog dependency to include djb's ucspi-tcp package (might also need tcp6) and change the syntax in the socklog-ucspi run file

socklog-conf.c and the manual page should be patched for this purpose.

I doubt this will be accepted here.

disable / remove socklog-ucspi

I believe you assume removal of the feature. See above.

modify the manpage to clarify that it won't work [...]

It would be nice to inform a user of tcpsvd coming with a separate package, but Void Linux is not the open based operating system with documentation stored in manual pages, meaning that void-specific documentation is handled in a different way (see void-docs).

Maybe it will be accepted at least there.

@leahneukirchen
Copy link
Member

Void depends are only for essential dependencies, if you configure socklog to use tcpsvd, it's your problem to have the appropriate tools installed.

(My suggestion was to actually add a preconfigured setup to the socklog-ucspi package, however.)

@sbromberger
Copy link
Contributor

Void depends are only for essential dependencies, if you configure socklog to use tcpsvd, it's your problem to have the appropriate tools installed.

Interesting. I hadn't thought of it this way before. In this case perhaps it's better to not create a runfile that is broken by default? If the user has to go through the steps of installing tcpsvd, then s/he is probably adept enough to create an appropriate service.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Dec 29, 2022
@ghost
Copy link
Author

ghost commented Dec 29, 2022

add a preconfigured setup to the socklog-ucspi package

I had my doubts for this new metapackage, but it seems I completely misunderstood your suggestion.

@leahneukirchen leahneukirchen merged commit 8e014a3 into void-linux:master Jan 2, 2023
@ghost ghost deleted the ipsvd branch January 8, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

void-socklog: ucspi is configured to use tcpsvd which doesn't exist.
3 participants