Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: limine-4.20230215.0 #41420

Merged
merged 1 commit into from Feb 15, 2023
Merged

Conversation

mintsuki
Copy link
Contributor

@mintsuki mintsuki commented Jan 3, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • i686
    • i686-musl
    • aarch64
    • aarch64-musl

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jan 3, 2023
@mintsuki mintsuki force-pushed the limine branch 3 times, most recently from e97d18e to e384858 Compare January 3, 2023 13:00
@mobinmob
Copy link
Contributor

mobinmob commented Jan 3, 2023

Thank you for (re)submiting a PR @mintsuki !
limine is an realy nice bootlader, it is ideal for live cds IMHO.

@mintsuki mintsuki force-pushed the limine branch 2 times, most recently from aebf7db to 729b7bb Compare January 16, 2023 16:53
@mintsuki mintsuki changed the title New package: limine-4.20221230.0 New package: limine-4.20230114.0 Jan 16, 2023
@mintsuki mintsuki changed the title New package: limine-4.20230114.0 New package: limine-4.20230120.0 Jan 22, 2023
@mobinmob
Copy link
Contributor

mobinmob commented Feb 4, 2023

Just 2 suggestions:

  • It may be a good thing to provide some documentation in the package. README.md, PROTOCOL.md and CONFIG.md can be installed with vdoc.
  • Please provide a sample limine.cfg in the package. The one under test/ will be fine.

@Vaelatern
Copy link
Member

This is attractive, though I personally have no use for it (being a heavy ZFS user)...

Do you have an idea as to if the cross built artifacts successfully boot a piece of hardware?

@mobinmob
Copy link
Contributor

mobinmob commented Feb 5, 2023

This is attractive, though I personally have no use for it (being a heavy ZFS user)...

I am planing to use limine with zfs in my main machine. Limine will act as an boot manager for uefi to load zfsbotmenu and as a chainloading bootloader.

I found 'limine.cfg' to be really straightforward. Barry Kauler, the creator of Puppy Linux and EasyOS has done work on a script that discovers any os on local disk and generates a proper configuration file, but have not studied it yet.

@mintsuki
Copy link
Contributor Author

mintsuki commented Feb 9, 2023

I wouldn't go as far as to chainload another bootloader for ZFS... that isn't really the point of Limine, but if you wanna use it in that fashion that's okay.

I would suggest reading the newly added PHILOSOPHY.md file in the root of the Limine repo for an idea behind the design and usage philosophy of the bootloader.

@mintsuki mintsuki changed the title New package: limine-4.20230120.0 New package: limine-4.20230208.0 Feb 9, 2023
@mintsuki
Copy link
Contributor Author

mintsuki commented Feb 9, 2023

This is attractive, though I personally have no use for it (being a heavy ZFS user)...

Do you have an idea as to if the cross built artifacts successfully boot a piece of hardware?

I wouldn't be able to tell you for sure, but what I can tell you is that it is exceedingly rare (never witnessed) a successful Limine build (regardless of environment) misbehave, bar actual Limine bugs, of course.

@mobinmob
Copy link
Contributor

mobinmob commented Feb 9, 2023

I wouldn't go as far as to chainload another bootloader for ZFS... that isn't really the point of Limine, but if you wanna use it in that fashion that's okay.

Ι will use limine to load the zfsbootmenu efi executable. That enables me to have boot environments (with native encryption optionally ). I will also use limine to load other kernels from the ESP.
I am currently using refind but I find limine configuration more straightforward.
It is fantastic on a livecd - single configuration for uefi and bios and easy installation.

I would suggest reading the newly added PHILOSOPHY.md file in the root of the Limine repo for an idea behind the design and usage philosophy of the bootloader.

I have already read it. It is refreshing to see a project that has a well-defined scope 👌

@mintsuki mintsuki changed the title New package: limine-4.20230208.0 New package: limine-4.20230212.0 Feb 12, 2023
@mintsuki mintsuki changed the title New package: limine-4.20230212.0 New package: limine-4.20230212.1 Feb 13, 2023
@mintsuki
Copy link
Contributor Author

@Vaelatern @classabbyamp
Is there anything wrong with the PR? Alternatively, is there an ETA for merge?

If Limine's notoriety is the issue blocking this PR, it may help to know it is packaged upstream for Alpine Linux, and it is the bootloader used to boot EasyOS (made by the Puppy Linux creator) which ranks 22nd on DistroWatch at the time of writing this.

@mintsuki mintsuki changed the title New package: limine-4.20230212.1 New package: limine-4.20230215.0 Feb 15, 2023
@Vaelatern Vaelatern merged commit 57e774a into void-linux:master Feb 15, 2023
@mintsuki mintsuki deleted the limine branch February 16, 2023 22:12
@fungilife

This comment was marked as off-topic.

@classabbyamp
Copy link
Member

please take your rants elsewhere

@void-linux void-linux locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants