Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-ansicolor: update to 0.3.2 #41475

Closed
wants to merge 1 commit into from

Conversation

zen0bit
Copy link
Contributor

@zen0bit zen0bit commented Jan 5, 2023

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x64 glibc)

It is needed for: ulozto-downloader

#41448

Without bump not working for me

Traceback (most recent call last): import colors ModuleNotFoundError: No module named 'colors'

(Actual working can't try because uloz.to have some dificulties right now..)

@realcharmer
Copy link
Contributor

Without bump not working for me

Traceback (most recent call last): import colors ModuleNotFoundError: No module named 'colors'

(Actual working can't try because uloz.to have some dificulties right now..)

Works for me pre and post-update of python3-ansicolor and ulozto-downloader as well. No issues.

@paper42
Copy link
Member

paper42 commented Jan 6, 2023

ulozto-downloader uses python3-ansiicolorS, so the dependency is incorrect and this PR doesn't fix it. @realcharmer could you package https://pypi.org/project/ansicolors/ and let ulozto-downloader depend on it in the same PR as the update? I suspect it works for you because you have it installed with pip.

@realcharmer
Copy link
Contributor

realcharmer commented Jan 6, 2023

ulozto-downloader uses python3-ansiicolorS, so the dependency is incorrect and this PR doesn't fix it. @realcharmer could you package https://pypi.org/project/ansicolors/ and let ulozto-downloader depend on it in the same PR as the update? I suspect it works for you because you have it installed with pip.

You are right, I've missed that. There is no python3-ansicolors package in Void, so I'll have to package that first.

@paper42
Copy link
Member

paper42 commented Jan 6, 2023

ulozto-downloader uses python3-ansiicolorS, so the dependency is incorrect and this PR doesn't fix it. @realcharmer could you package pypi.org/project/ansicolors and let ulozto-downloader depend on it in the same PR as the update? I suspect it works for you because you have it installed with pip.

You are right, I've missed that. There is no python3-ansicolors package in Void, so I'll have to package that first.

Please do that in the update PR in a separate commit.

@realcharmer
Copy link
Contributor

Please do that in the update PR in a separate commit.

You mean the dependency fix in ulozto-downloader template or adding python3-ansicolors?

@paper42
Copy link
Member

paper42 commented Jan 6, 2023

both in the same PR, one commit per package, so it should be something like

  • ulozto-downloader: update to xxx, fix dep
  • New package: python3-ansicolors-x.x.x

@realcharmer
Copy link
Contributor

Done in #41448.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 7, 2023
@github-actions github-actions bot closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants