Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: nostr-rs-relay #41558

Closed
wants to merge 1 commit into from
Closed

New package: nostr-rs-relay #41558

wants to merge 1 commit into from

Conversation

strec007
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • x86_64-musl

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jan 10, 2023
@strec007 strec007 force-pushed the _pc_nostr-rs-relay branch 2 times, most recently from c253504 to 5e3f10b Compare February 22, 2023 16:55
@strec007 strec007 marked this pull request as draft February 22, 2023 17:27
@icp1994
Copy link
Contributor

icp1994 commented Feb 22, 2023

The two "hostmakedepends" must be a single line, otherwise the second one overwrites the first one iirc.

@strec007
Copy link
Contributor Author

@icp1994 Oh, I completely oversaw it. Thanks!

@strec007 strec007 force-pushed the _pc_nostr-rs-relay branch 2 times, most recently from 2938ff8 to 80fd344 Compare February 22, 2023 21:26
@strec007 strec007 marked this pull request as ready for review February 22, 2023 21:58
classabbyamp
classabbyamp reviewed May 10, 2023
View reviewed changes
Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://git.sr.ht/~gheartsfield/nostr-rs-relay/tree/0.8.9/item/config.toml should probably be installed, maybe using vsconf

srcpkgs/nostr-rs-relay/template Outdated Show resolved Hide resolved
srcpkgs/nostr-rs-relay/template Outdated Show resolved Hide resolved
srcpkgs/nostr-rs-relay/template Outdated Show resolved Hide resolved
@strec007 strec007 force-pushed the _pc_nostr-rs-relay branch 3 times, most recently from 22e3b8d to 5938881 Compare May 10, 2023 18:23
@classabbyamp
Copy link
Member

this is meant to run as a service, right? would it make sense to add a runit service?

@strec007
Copy link
Contributor Author

this is meant to run as a service, right? would it make sense to add a runit service?

Right. That's a good idea. Thanks. I'll add it.

classabbyamp
classabbyamp reviewed May 10, 2023
View reviewed changes
srcpkgs/nostr-rs-relay/INSTALL Outdated
Comment on lines 5 to 6
mkdir $DBDIR
chown _nostr:_nostr $DBDIR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the make_dirs variable instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, cool thing. Thanks. And done.

Duncaen
Duncaen reviewed May 10, 2023
View reviewed changes
srcpkgs/nostr-rs-relay/template Outdated
distfiles="https://git.sr.ht/~gheartsfield/nostr-rs-relay/archive/${version}.tar.gz"
checksum=a497340760fc99745fdb42c7ea04013d25bc57e50ca4749887129361866a98fa
system_accounts="_nostr"
system_groups="_nostr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably use _nostr_rs_relay for user and group names just so that there won't be any future conflicts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that makes sense....

@TinfoilSubmarine
Copy link
Contributor

0.8.12 is out

@github-actions GitHub Actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Nov 23, 2023
@github-actions github-actions bot closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duncaen Duncaen Duncaen left review comments

@classabbyamp classabbyamp classabbyamp left review comments

Assignees
No one assigned
Labels
new-package This PR adds a new package Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@strec007 @icp1994 @classabbyamp @TinfoilSubmarine @Duncaen