devilutionX: update to 1.4.1. #41658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaelatern
requested changes
Jan 15, 2023
|
Is there a source for |
There is, but my main concern is that its last release was in 2016, last change to the code in 2018. If it is alright, I will package it for you properly. |
|
As discussed on IRC, @kruceter will try to ask upstream to change tools from |
* External (3rd party) dependencies normally are fetched with git, which is undesirable for packaging; hence they are fetched manually with xbps-src. "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" prevents cmake's FetchContent module from attempting to download or update any external dependencies. * BINARY_RELEASE option is gone. * CharisSILB is absent with TTF_FONT_PATH from the release tarball.
|
Apparently upstream ships tarball with all external dependencies bundled. Not only that, they also have pre-archived @Vaelatern has my sincere gratitude for pointing it out. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
About mpqtool
Apparently upstream needs some tool to pack assets into one file.If such a tool is not used within CMake,do_install()will not install the binary, icons, etc to$DESTDIR.Pull request #39184 had encountered this behaviour and placed needed files manually as a result.Packagingsmpqis a little too much, hencempqtoolis used with little patching to address all issues listed above.