Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim-remote: update to 2.5.1 #41659

Closed

Conversation

andrelcmoreira
Copy link
Contributor

@andrelcmoreira andrelcmoreira commented Jan 15, 2023

Testing the changes

  • I tested the changes in this PR: briefly

@andrelcmoreira andrelcmoreira changed the title neovim-remote: update to 2.5.1 WIP: neovim-remote: update to 2.5.1 Jan 15, 2023
@paper42 paper42 added the needs-testing Testing a PR or reproducing an issue needed label Jan 15, 2023
@andrelcmoreira andrelcmoreira changed the title WIP: neovim-remote: update to 2.5.1 neovim-remote: update to 2.5.1 Jan 15, 2023
@andrelcmoreira andrelcmoreira marked this pull request as ready for review January 15, 2023 21:34
@andrelcmoreira
Copy link
Contributor Author

andrelcmoreira commented Jan 21, 2023

I executed the basic test cases below (which are my main use cases) with success for both 2.4.0 and 2.5.1 versions:

test 1: open files remotely - OK

$ nvim --listen /tmp/nvimsocket
$ nvr --remote file_1 file_2

test 2: send commands to the current buffer - OK

$ nvim --listen /tmp/nvimsocket
$ nvr --remote file_1
$ nvr --remote-send 'ihello, world!<esc>yypppppp:w<enter>'
$ nvr --remote-send 'dd:w<enter>'
$ nvr --remote-send '5k'
$ nvr --remote-send '5j'

test 3: running expressions in the current buffer - OK

$ nvim --listen /tmp/nvimsocket
$ nvr --remote file_1
$ nvr --remote-expr 'bufname("")'
$ nvr --remote-expr 'getline(5)'
$ nvr --remote-expr 'getpid()'

test 4: recording and running macros - OK

$ nvim --listen /tmp/nvimsocket
$ nvr --remote file_1
$ nvr --remote-send 'ihello, world!<esc>yypppppppppp:w<enter>'
$ nvr --remote-send 'qbggVGU:w<enter>q'
$ nvr --remote-send '@b'

Any other contributions are welcome :D

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 22, 2023
@github-actions github-actions bot closed this May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-testing Testing a PR or reproducing an issue needed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants