Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WoeUSB: make some room for uefi image. #41669

Closed
wants to merge 1 commit into from
Closed

WoeUSB: make some room for uefi image. #41669

wants to merge 1 commit into from

Conversation

sinetek
Copy link

@sinetek sinetek commented Jan 15, 2023

Add a patch for WoeUSB. Version of the program stays the same.
The patch is required because one of the files that is used, downloaded from a github repository at runtime, has doubled in size, and so a small change in the code is needed to accommodate this boot file.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

@classabbyamp
Copy link
Member

classabbyamp commented Jan 15, 2023

looks like this has been fixed upstream already in v5.1.3. might be better to just update

@sinetek
Copy link
Author

sinetek commented Jan 15, 2023

looks like this has been fixed upstream already in v5.1.3. might be better to just update

Someone tried to update to 5.1.3 but the pull request was closed for reasons I don't understand. This just fixes the current package instead of trying to migrate to the new project which has a different code base.

@classabbyamp
Copy link
Member

looks like it was closed because the author never finished working on requested changes

@sinetek
Copy link
Author

sinetek commented Jan 15, 2023

It could be done as subsequent work I suppose. I'm not interested at this time to do it.

@ghost
Copy link

ghost commented Jan 20, 2023

WoeUSB was separated into WoeUSB-cli and updated in d4625ea.

@sinetek
Copy link
Author

sinetek commented Jan 31, 2023

WoeUSB was separated into WoeUSB-cli and updated in d4625ea.

Woeusb-cli is not the same program. As I understand it, it is a command line client, this is a GUI.

@ghost
Copy link

ghost commented Jan 31, 2023

As I understand it, it is a command line client, this is a GUI.

gui is a wrapper for WoeUSB-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants