Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glslang and shaderc to the current version. #41693

Closed
wants to merge 2 commits into from

Conversation

dataCobra
Copy link
Contributor

@dataCobra dataCobra commented Jan 17, 2023

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

The update is also necessary for Godot 4 to be able to use the shared library instead of the
builtin glslang.

@dataCobra
Copy link
Contributor Author

I hope somebody can help me with the PR.

Since just updating the version and checksum didn't worked I used the way that Archlinux does
the PKGBUILD.

I tried also to get SPIRV-Tools-devel and SPIRV-Headers to link against the glslang but this
didn't work. If we could get this working this would help a lot.

@TheKeyboard3
Copy link

TheKeyboard3 commented Jan 18, 2023

glslang compiles and passes tests with just the version and the checksum updated, as well as the "vmove "usr/lib/*.a"" line removed because no static libraries are created. If the lack of static libraries is an issue for other packages, the cmake files of the pakcage should be looked into

@TheKeyboard3
Copy link

I`ve looked into the cmake files and found out that building shared libraries and statically linked libraries is mutually exclusive in the never versions of glslang, but the static libraries are necesarry for shaderc

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 30, 2023
@github-actions github-actions bot closed this May 14, 2023
@dataCobra dataCobra deleted the glslang branch May 15, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants