Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: radio-sh-2.0 #41737

Closed
wants to merge 1 commit into from

Conversation

Singustromo
Copy link

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-LIBC)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jan 19, 2023
@classabbyamp
Copy link
Member

  1. System: The software should be installed system-wide, not per-user.
  2. Compiled: The software needs to be compiled before being used, even if it is software that is not needed by the whole system.
  3. Required: Another package either within the repository or pending inclusion requires the package.

[...] Simple shell scripts are unlikely to be accepted unless they provide considerable value to a broad user base. [...]

from CONTRIBUTING.md

how does this meet those requirements?

@ahesford
Copy link
Member

This belongs in ~/bin, not a distribution package.

@ahesford ahesford closed this Jan 19, 2023
@Singustromo
Copy link
Author

Singustromo commented Jan 19, 2023

  1. System: The software should be installed system-wide, not per-user.
  2. Compiled: The software needs to be compiled before being used, even if it is software that is not needed by the whole system.
  3. Required: Another package either within the repository or pending inclusion requires the package.

[...] Simple shell scripts are unlikely to be accepted unless they provide considerable value to a broad user base. [...]

from CONTRIBUTING.md

how does this meet those requirements?

All right, I thought it might be something worth adding since there are also packages like #14199 with similar functionality but also with more dependencies. PyRadio - in the end of the day - is also a wrapper for mpv.

@ahesford
Copy link
Member

It's not about the length of the shell script, but whether

curl -L -O ~/bin/output.sh https://some-url-for-download

is equivalent to

xbps-install some-package

and, for a single shell script that is intended for individual use on a personal computer, is generally true. It is certainly true here. The PyRadio package requires a proper installation and integration into the system's python ecosystem (or else venv management) and is therefore a candidate for packaging.

@Singustromo
Copy link
Author

Singustromo commented Jan 19, 2023

Thank you for the explanation. I did not think of it this way.

Is there another way - in general - to share such things in an unobtrusive manner?

@Singustromo Singustromo deleted the new-pkg_radio-sh branch January 19, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants