Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: drawing-1.0.1 #41748

Closed
wants to merge 1 commit into from
Closed

New package: drawing-1.0.1 #41748

wants to merge 1 commit into from

Conversation

Zoh-j02r
Copy link

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-GLIBC)

Previous attempts to porting this package seems to be abandoned; #37153 #32839.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jan 19, 2023
@Zoh-j02r
Copy link
Author

now it builds for other archs, I didn't pay attention to hostmake and didn't use xlint.

@abenson
Copy link
Contributor

abenson commented Jan 20, 2023

The commits need to be squashed into a single "New package" commit. I still don't think the hostmakedepends/makedepends are correct. python3-devel should probably go into makedepends. gettext-devel typically needs to go in both because it has devel utilities and target libraries. gtk+3 shouldn't be in depends as it should be automatically detected.

@Zoh-j02r
Copy link
Author

I tested the package with depends=gtk+3 and without, for some reason drawing is unable to set gtk as a dependency

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 21, 2023
@github-actions github-actions bot closed this May 6, 2023
@Zoh-j02r Zoh-j02r deleted the drawing-testing branch May 7, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants