Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: clapboard-0.1.1 #41914

Closed
wants to merge 1 commit into from
Closed

Conversation

lz-coder
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-GLIBC)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jan 28, 2023
@icp1994
Copy link
Contributor

icp1994 commented Jan 28, 2023

License is MIT and using /archive/refs/tags/ is recommended for distfiles

@lz-coder lz-coder force-pushed the clapboard branch 2 times, most recently from 159b4d9 to 64d9271 Compare January 28, 2023 14:25
@lz-coder
Copy link
Contributor Author

License is MIT and using /archive/refs/tags/ is recommended for distfiles

Done

@icp1994
Copy link
Contributor

icp1994 commented Jan 28, 2023

If you overwrite do_install() from the cargo build style, the actual binary won't be in the package if you don't put it in the destdir manually. So your package currently contains only the LICENSE file. You can check this with xls from xtools. So you need post_install() instead of do_install().

@lz-coder
Copy link
Contributor Author

If you overwrite do_install() from the cargo build style, the actual binary won't be in the package if you don't put it in the destdir manually. So your package currently contains only the LICENSE file. You can check this with xls from xtools. So you need post_install() instead of do_install().

@lz-coder lz-coder closed this Jan 28, 2023
@lz-coder lz-coder reopened this Jan 28, 2023
@lz-coder
Copy link
Contributor Author

If you overwrite do_install() from the cargo build style, the actual binary won't be in the package if you don't put it in the destdir manually. So your package currently contains only the LICENSE file. You can check this with xls from xtools. So you need post_install() instead of do_install().

Thanks for the tip, I didn't know xls

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 29, 2023
@lz-coder lz-coder closed this May 4, 2023
@lz-coder lz-coder deleted the clapboard branch May 4, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants