python-msp430-tools: use python3 #42223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sgtm, I can't test it as I don't work with MSP430 currently. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Can you rebase? |
python2, not used by any other packages anymore
classabbyamp
force-pushed
the
msp430-tools-python3
branch
from
07259f9
to
592b62a
Compare
|
I think it might be better to just recommend using a py2 venv + pip2 for msp430-tools too. upstream has done 1 commit in the past 5 years, no indication of them moving most of the package to py3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
The readme mentions that python2 is needed for most modules, but we are slowly removing python2 packages, so I would recommend people to use a python2 venv and pip.
cc @leahneukirchen