yank: update to 1.3.0. #42332
Merged
yank: update to 1.3.0. #42332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icp1994
force-pushed
the
yank
branch
2 times, most recently
from
419bed1
to
9a9ab92
Compare
paper42
reviewed
Mar 6, 2023
Comment on lines
+7
to
+8
| make_build_args="YANKCMD=$(vopt_if wayland wl-copy xsel)" | ||
| depends="$(vopt_if wayland wl-clipboard xsel)" |
There was a problem hiding this comment.
hmm, this is unfortunate, isn't there a way to build with both xsel and wl-copy support?
There was a problem hiding this comment.
https://github.com/mptre/yank/blob/v1.3.0/yank.c#L470 hardcoded, gets resolved during compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
I want to use this pkg in wayland so I added the build options, keeping the default as same as before.