New package: colmap-3.8 #42457
Closed
New package: colmap-3.8 #42457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srcpkgs/metis/template
Outdated
Comment on lines
5
to
6
| build_style=gnu-makefile | ||
| hostmakedepends="cmake" |
There was a problem hiding this comment.
why not just use the cmake build style?
There was a problem hiding this comment.
Even though this has a custom do_configure()? If that's okay, then sure.
There was a problem hiding this comment.
you shouldn't need to touch their weird makefile -- it runs cmake internally
There was a problem hiding this comment.
The makefile does do one important thing - resolve the absolute path the the GKlib folder. If that isn't passed to CMake, then I get configure errors.
Could have been done within CMake, but doing it ourselves isn't too bad.
agausmann
force-pushed
the
colmap-3.8
branch
from
f3567bb
to
17d43b5
Compare
agausmann
force-pushed
the
colmap-3.8
branch
from
17d43b5
to
17ff194
Compare
|
Closing since I am no longer using it and don't want to maintain it. If somebody else wants to pick this up, feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package