Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk17: static-libs subpackage #42526

Merged
merged 3 commits into from Mar 16, 2023

Conversation

classabbyamp
Copy link
Member

  • openjdk11: remove useless nostrep from -static-libs
  • openjdk17: static libs subpackage

Testing the changes

  • I tested the changes in this PR: NO

@classabbyamp classabbyamp added the needs-testing Testing a PR or reproducing an issue needed label Mar 1, 2023
@icp1994
Copy link
Contributor

icp1994 commented Mar 1, 2023

mandrel-update-to-22.3.1.0.txt

If you add another commit with this patch and it builds, I'd say that's probably enough to infer it works.

@classabbyamp
Copy link
Member Author

cool, thanks

@classabbyamp classabbyamp force-pushed the openjdk17-static branch 3 times, most recently from 5a927f5 to 3cb108d Compare March 5, 2023 07:25
@icp1994
Copy link
Contributor

icp1994 commented Mar 5, 2023

Seems like better to use https://github.com/openjdk/jdk11u/tags for jdk11 distfile similar to the jdk17 one

edit: update-check broken too for jdk11, maybe worth a separate PR for jdk11 related things

@classabbyamp classabbyamp force-pushed the openjdk17-static branch 2 times, most recently from bddac2b to a31eb76 Compare March 5, 2023 08:31
@classabbyamp
Copy link
Member Author

heh right, that issue

@classabbyamp

This comment was marked as resolved.

it wasn't doing anything anyways, it was "notstrip"

also fix distfile source, update check
@classabbyamp classabbyamp removed the needs-testing Testing a PR or reproducing an issue needed label Mar 16, 2023
@classabbyamp classabbyamp merged commit 9781d38 into void-linux:master Mar 16, 2023
7 of 8 checks passed
@classabbyamp classabbyamp deleted the openjdk17-static branch March 16, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants