Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pcakages: rpi-libcamera:20230303 and rpi-libcamera-apps-1.1.2 #42579

Closed
wants to merge 2 commits into from

Conversation

strec007
Copy link
Contributor

@strec007 strec007 commented Mar 3, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64

@classabbyamp classabbyamp added the new-package This PR adds a new package label Mar 3, 2023
@strec007 strec007 changed the title New pcakage: rpi-libcamera-apps-1.1.1 New pcakage: rpi-libcamera-apps-1.1.2 Mar 4, 2023
@strec007
Copy link
Contributor Author

strec007 commented Mar 4, 2023

int conversion issue has been fixed in v.1.1.2, now all builds work.

This package depends on rpi-libcamera which has not been integrated yet (PR #42574). Is it OK to create a dependent pull request like this? Thank you.

@strec007 strec007 marked this pull request as ready for review March 4, 2023 10:42
@classabbyamp
Copy link
Member

put everything in 1 pull request

@strec007
Copy link
Contributor Author

strec007 commented Mar 4, 2023

put everything in 1 pull request

In that case, this is the one pull request containing all changes. Including those from PR #42579, which I close. Thank you.

@strec007 strec007 changed the title New pcakage: rpi-libcamera-apps-1.1.2 New pcakages: rpi-libcamera:20230303 and rpi-libcamera-apps-1.1.2 Mar 4, 2023
Comment on lines +4241 to +4242
libcamera.so.0.0.4 rpi-libcamera-230303_1
libcamera-base.so.0.0.4 rpi-libcamera-230303_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the same sonames as what the libcamera package has, so this won't work correctly once #41263 is merged.

PLEASE NOTE: when multiple packages provide the same SONAME, the first one (order top->bottom) is preferred over the next ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so what's the solution of this? The user should be able to choose if they want libcamera, or rpi-libcamera (on Raspberry Pi). I understand that I should add the conflicts variable specifying libcamera package but how can we avoid the conflict in common/shlibs?

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 4, 2023
@github-actions github-actions bot closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants