Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runit-void: move os-release to base-files #42657

Closed
wants to merge 1 commit into from

Conversation

ahesford
Copy link
Member

@ahesford ahesford commented Mar 8, 2023

The os-release file really has nothing to do with runit and should be present even in the most basic installation, so it belongs in base-files. This also fixes some problems with meson calling Python's platform for host information in Void build containers (which don't install runit-void).

Testing the changes

  • I tested the changes in this PR: briefly

@eli-schwartz
Copy link

This also fixes some problems with meson calling Python's platform for host information in Void build containers (which don't install runit-void).

The thing is that meson still doesn't read this file as far as I can tell, not even by the platform module, since the only function that attempts to read it is platform.freedesktop_os_release().

Not that it's a bad idea to move the os-release file, but I still don't understand how it's even possible to get a meson error here.

@classabbyamp
Copy link
Member

classabbyamp commented Mar 8, 2023

the meson issue was a false alarm, I misread something, but i still think this is a good idea.

should /etc/hostname and /etc/locale.conf also be moved? those don't seem runit-related?

@ahesford
Copy link
Member Author

ahesford commented Mar 9, 2023

should /etc/hostname and /etc/locale.conf also be moved? those don't seem runit-related?

That makes sense, so I made the change here.

@classabbyamp
Copy link
Member

hm, the fact that those are conf files may cause issues. @Duncaen thoughts?

@ahesford
Copy link
Member Author

ahesford commented Mar 9, 2023

Forcing a reinstallation to test the move caused my hostname file ti he inadvertently replaced, so there does seem to be risk here. If we can't avoid this, it may make sense to leave the conf files where they started.

@ahesford
Copy link
Member Author

ahesford commented Mar 9, 2023

XBPS forgets about files marked as conf_files during the transition and will overwrite whatever is currently there. Abandoning the hostname and locale moves for now to avoid catastrophe.

Cf. void-linux/xbps#342 void-linux/xbps#426

@ahesford ahesford closed this Mar 9, 2023
@ahesford ahesford deleted the all_your_base branch March 9, 2023 21:03
@ahesford
Copy link
Member Author

ahesford commented Mar 9, 2023

76f9490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants