-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runit-void: move os-release to base-files #42657
Conversation
The thing is that meson still doesn't read this file as far as I can tell, not even by the platform module, since the only function that attempts to read it is Not that it's a bad idea to move the os-release file, but I still don't understand how it's even possible to get a meson error here. |
the meson issue was a false alarm, I misread something, but i still think this is a good idea. should |
That makes sense, so I made the change here. |
hm, the fact that those are conf files may cause issues. @Duncaen thoughts? |
Forcing a reinstallation to test the move caused my hostname file ti he inadvertently replaced, so there does seem to be risk here. If we can't avoid this, it may make sense to leave the conf files where they started. |
XBPS forgets about files marked as |
The
os-release
file really has nothing to do with runit and should be present even in the most basic installation, so it belongs inbase-files
. This also fixes some problems with meson calling Python'splatform
for host information in Void build containers (which don't installrunit-void
).Testing the changes