Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qutebrowser testing #42733

Closed
wants to merge 4 commits into from
Closed

Qutebrowser testing #42733

wants to merge 4 commits into from

Conversation

jason1987d
Copy link
Contributor

@jason1987d jason1987d commented Mar 12, 2023

Three packages listed in qutebrowser template as needed for testing it that are not currently packaged in void linux.
#42344

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (ARCH-LIBC)

@paper42
Copy link
Member

paper42 commented Mar 13, 2023

Please also enable tests in qutebrowser in this PR so we can see this works

revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3 python3-pytest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3-pytest already depends on python3:

Suggested change
depends="python3 python3-pytest"
depends="python3-pytest"

revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3 python3-pytest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends="python3 python3-pytest"
depends="python3-pytest"

revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3 python3-pytest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends="python3 python3-pytest"
depends="python3-pytest"

@jason1987d jason1987d marked this pull request as draft March 13, 2023 17:27
@jason1987d
Copy link
Contributor Author

I got hold of The-Compiler himself,

ah, I see the issue... we don't package scripts/dev/ in releases (because
those are development scripts), but we have tests for it
as a quick workaround, can you try just removing
tests/unit/scripts/test_check_coverage.py
tests/unit/scripts/test_problemmatchers.py and
tests/unit/scripts/test_run_vulture.py maybe?

@jason1987d
Copy link
Contributor Author

Word is that qt6 branch will be merged soon.

@jason1987d jason1987d closed this Mar 16, 2023
@jason1987d jason1987d deleted the qutebrowser-testing branch March 16, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants