Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] conky: update to 1.19.1 #42879

Closed
wants to merge 1 commit into from
Closed

Conversation

realcharmer
Copy link
Contributor

@realcharmer realcharmer commented Mar 20, 2023

Changes

  • Bump version
  • Fixed 32-bit tests upstream
  • Do not build docs

Wayland support and/or package merge of conky and conky-cli can be explored in the future.

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@realcharmer
Copy link
Contributor Author

Tests fail on i686. I've filled a bug in upstream brndnmtthws/conky#1463. Is is possible the issue is on our side?

@realcharmer
Copy link
Contributor Author

realcharmer commented Mar 20, 2023

I didn't notice the old PR #40237. It seems like this is going to need more work. I will try and implement the suggestions from the mentioned PR. We could label this as WIP for now.

@realcharmer
Copy link
Contributor Author

The mentioned bug has been fixed by brndnmtthws/conky#1470, so we should wait for a new release to have passing builds for i686.

@realcharmer realcharmer changed the title conky: update to 1.18.3 [WIP] conky: update to 1.18.3 Mar 28, 2023
@realcharmer realcharmer changed the title [WIP] conky: update to 1.18.3 [WIP] conky: update to 1.19.0 Apr 3, 2023
@realcharmer
Copy link
Contributor Author

realcharmer commented Apr 3, 2023

There is a new release 1.19.0 for conky, so I've updated the PR and commit. It turns out there are more test failures on 32bit systems. See more at brndnmtthws/conky#1485.

Waiting for upstream fixes and a subsequent new release.

@ncmprhnsbl
Copy link

1.19.1 is now out.
something else to think about is conky is now wayland compatible (with: -DBUILD_WAYLAND=ON )
(and conkyconf: out_to_wayland = true )
this could be added to the plain conky build or a third "conky-wayland" template added that has DBUILD_X11=OFF as well as the wayland flag..

@realcharmer
Copy link
Contributor Author

realcharmer commented Apr 25, 2023

conky is now wayland compatible (with: -DBUILD_WAYLAND=ON ) (and conkyconf: out_to_wayland = true ) this could be added to the plain conky build or a third "conky-wayland" template added that has DBUILD_X11=OFF as well as the wayland flag..

Why not both? Are they mutually exclusive? Enabling both would cover most use-cases. Judging by the previous closed PR #40237, splitting conky into multiple packages is not a good idea. Also thanks for the version bump heads-up.

@realcharmer realcharmer changed the title [WIP] conky: update to 1.19.0 [WIP] conky: update to 1.19.1 Apr 25, 2023
@ncmprhnsbl
Copy link

ncmprhnsbl commented Apr 25, 2023

Why not both?

;) is what i meant when i said:

this could be added to the plain conky build or

which is fine by me and afaik they're not mutually exclusive
seems the build has gotten caught in a libcurl update...

@ncmprhnsbl
Copy link

a couple of things when i try to build this locally with xbps-src:
need to add: wayland-devel and wayland-protocols to the makedepends
but even then compilation fails at "display-wayland.cc.o" unable to find cairo.h even though it's definitely present in the buildroot

@realcharmer realcharmer force-pushed the conky branch 2 times, most recently from 21534b1 to b0ac0d8 Compare May 2, 2023 07:34
@realcharmer
Copy link
Contributor Author

I don't have time to work on this now. Feel free to continue with my changes. Upstream for 32bit is fixed, so that's something at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants