New package: bubbletea-0.23.2 #43083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it expose executable, C API, or anything useful? If it is just go API, it won't be useful, as Go programs are full-source built. |
abenson
reviewed
Mar 28, 2023
| post_install() { | ||
| vlicense LICENSE | ||
|
|
||
| #vtargetrun ${pkgname} man > ${pkgname}.1 |
There was a problem hiding this comment.
If these aren't going to be run, they should be removed. Why are they commented out?
triallax
reviewed
Mar 29, 2023
| license="MIT" | ||
| homepage="https://github.com/charmbracelet/bubbletea" | ||
| changelog="https://github.com/charmbracelet/bubbletea/releases" | ||
| distfiles="https://${go_import_path}/archive/v${version}.tar.gz" |
There was a problem hiding this comment.
Suggested change
| distfiles="https://${go_import_path}/archive/v${version}.tar.gz" | |
| distfiles="https://github.com/charmbracelet/bubbletea/archive/v${version}.tar.gz" |
I don't think this is packageable because it's purely a go library, which can only be statically linked to an application in its current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing