Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New packages: rustypaste-0.8.4, rustypaste-cli-0.3.0 #43118

Merged
merged 2 commits into from
Apr 6, 2023
Merged

New packages: rustypaste-0.8.4, rustypaste-cli-0.3.0 #43118

merged 2 commits into from
Apr 6, 2023

Conversation

lukas-jo
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • armv6l

@classabbyamp classabbyamp added the new-package This PR adds a new package label Mar 30, 2023
@tranzystorekk
Copy link
Contributor

Please add changelog as well

@icp1994
Copy link
Contributor

icp1994 commented Mar 30, 2023

Is there a reference public instance? If not does it make sense to package it without rustypaste itself?

@lukas-jo
Copy link
Contributor Author

There is no public instance as far as I know.
Since the system the rustypaste server is installed on isn't necessarily a Void System, it shouldn't be necessary to have the server in the repos just to use the cli. However I'm not opposed to also package the server. I'd be happy to make a PR for that, but I don't think it should be in the way of putting the cli in the repos.

@classabbyamp
Copy link
Member

please add the server to this pr

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Mar 30, 2023 •
edited
Loading

Got a template for rustypaste laying around: tranzystorekk@38ee7e5

@lukas-jo
Copy link
Contributor Author

Got a template for rustypaste laying around: tranzystorek-io@38ee7e5

Does this build successfully for you? I tried my own template yesterday and it fails the check phase for x86_64-musl (armv6l works though).

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Mar 31, 2023 •
edited
Loading

Does this build successfully for you? I tried my own template yesterday and it fails the check phase for x86_64-musl (armv6l works though).

Good point, it fails a few tests, haven't investigated why, but probably because of port related stuff. The actual package works afaik.

@lukas-jo
Copy link
Contributor Author

lukas-jo commented Mar 31, 2023 •
edited
Loading

Does this build successfully for you? I tried my own template yesterday and it fails the check phase for x86_64-musl (armv6l works though).

Good point, it fails a few tests, haven't investigated why, but probably because of port related stuff. The actual package works afaik.

I managed to solve most of it by using cargo test -- --test-threads 1 in do_check as stated in the rustypaste README, but it still fails one test. I'm still investigating too

EDIT: @tranzystorek-io it builds successfully now, I just had to remove some files, that were left from a previous run

@lukas-jo lukas-jo changed the title New package: rustypaste-cli-0.3.0 New packages: rustypaste-0.8.4, rustypaste-cli-0.3.0 Mar 31, 2023
@lukas-jo lukas-jo force-pushed the rpaste branch 3 times, most recently from 4629559 to b24b19a Compare March 31, 2023 11:58
tranzystorekk
tranzystorekk approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@tranzystorekk tranzystorekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukas-jo
Copy link
Contributor Author

lukas-jo commented Mar 31, 2023 •
edited
Loading

wait, I blundered. I messed up the urls

EDIT: fixed

@classabbyamp classabbyamp merged commit 0209bb9 into void-linux:master Apr 6, 2023
@lukas-jo lukas-jo deleted the rpaste branch April 6, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tranzystorekk tranzystorekk tranzystorekk approved these changes

@classabbyamp classabbyamp Awaiting requested review from classabbyamp

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukas-jo @tranzystorekk @icp1994 @classabbyamp