comrak: update to 0.18.0. #43167
Merged
comrak: update to 0.18.0. #43167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comrak uses oniguruma, we can link void's dynlibs |
|
Sorry, hadn't seen your PR, but you're right, we should link oniguruma dynamically |
jcgruenhage
force-pushed
the
comrak-0.18.0_1
branch
from
bb626b1
to
b58b30a
Compare
|
To make sure this linking is happening automatically the way we'd want it to, I've added the env var to the rust build helper instead of the comrak template. If I should split that out into a separate PR though, I could do that as well. |
There was a problem hiding this comment.
Is the rust helper included automatically?
There was a problem hiding this comment.
build_style=cargo includes build_helper=rust, yea
There was a problem hiding this comment.
jcgruenhage
force-pushed
the
comrak-0.18.0_1
branch
from
b58b30a
to
49f6f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes