Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foot: update to 1.14.0. #43328

Merged
merged 1 commit into from
Apr 12, 2023
Merged

foot: update to 1.14.0. #43328

merged 1 commit into from
Apr 12, 2023

Conversation

icp1994
Copy link
Contributor

@icp1994 icp1994 commented Apr 7, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture: x86_64

\cc @ifreund

@cinerea0
Copy link
Contributor

cinerea0 commented Apr 7, 2023

libutempter should be added to makedepends and depends. This release adds support for writing log files using it. Adding it to makedepends is necessary for the build process to autodetect where utempter lives in the filesystem (though this can also be set using -Ddefault-utempter-path), and adding it to depends manually is necessary because xbps doesn't detect the shlib automatically. I've been testing this for a couple days and was about to open my own PR, so otherwise this looks good.

@icp1994
Copy link
Contributor Author

icp1994 commented Apr 8, 2023

mmm, okay - I wasn't sure whether to add it or not since it's marked as optional.

@icp1994
Copy link
Contributor Author

icp1994 commented Apr 8, 2023

I think I figured why xbps is not detecting the shlib. It's cause the the binary is not actually linked to the sofile. So it's just a runtime dependency, -devel not required for building.

@classabbyamp classabbyamp merged commit 805c322 into void-linux:master Apr 12, 2023
@icp1994 icp1994 deleted the foot branch April 13, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants