Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnucash: update to 5.3, enable SQL support + add libdbi packages #43386

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

cinerea0
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc (crossbuilds disabled for gnucash)

cc: @manfredu

@cinerea0
Copy link
Contributor Author

A few things I wanted to point out:

  • gnucash's changelog is hosted on GitHub along with a mirror of its source code. That repo also hosts the same release tarballs that are hosted on SourceForge, so the distfiles could be set to that instead if we wanted to move away from SourceForge.
  • The reason I split libdbi and libdbi-drivers as much as I did is because the docs subpackages are larger and have far more files than the base packages, and they contain information only relevant to developers.
  • I added libdbi-drivers as a dependency to gnucash because, while it isn't required for basic functionality, you can't use the SQL backends without it.

@sgn
Copy link
Member

sgn commented Apr 11, 2023

I think it's better to split those 3 files into 3 packages:

/usr/lib/dbd/libdbdmysql.so
/usr/lib/dbd/libdbdpgsql.so
/usr/lib/dbd/libdbdsqlite3.so

Those files isn't that big itself, but I guess they will pull libmariaclient and libpgsql in which is big (I guess).

@cinerea0
Copy link
Contributor Author

I think it's better to split those 3 files into 3 packages

In addition to or instead of the current splits?

@sgn
Copy link
Member

sgn commented Apr 11, 2023

I think it's better to split those 3 files into 3 packages

In addition to or instead of the current splits?

In addition to current split.

@cinerea0
Copy link
Contributor Author

Moving each library out into its own package results in the main package being empty. Taking the trick from mpg123-extras and installing the readme as documentation doesn't work because all of the documentation is moved into libdbi-drivers-doc. Is there an another workaround?

@sgn
Copy link
Member

sgn commented Apr 12, 2023

build_style=meta, I would say, or let sqlite3, which is the lite version stay in main package.

@cinerea0 cinerea0 force-pushed the gnucash branch 6 times, most recently from ed08e6f to dd56e9e Compare April 14, 2023 02:46
@cinerea0 cinerea0 changed the title gnucash: update to 5.0, enable SQL support + add libdbi packages [WIP] gnucash: update to 5.0, enable SQL support + add libdbi packages Apr 14, 2023
@cinerea0 cinerea0 force-pushed the gnucash branch 7 times, most recently from 18d0a51 to ac276d9 Compare June 27, 2023 19:26
@cinerea0 cinerea0 force-pushed the gnucash branch 3 times, most recently from 1a1de04 to 6dbbf47 Compare July 31, 2023 17:09
@cinerea0 cinerea0 changed the title [WIP] gnucash: update to 5.0, enable SQL support + add libdbi packages [WIP] gnucash: update to 5.3, enable SQL support + add libdbi packages Jul 31, 2023
@cinerea0 cinerea0 changed the title [WIP] gnucash: update to 5.3, enable SQL support + add libdbi packages gnucash: update to 5.3, enable SQL support + add libdbi packages Jul 31, 2023
@Duncaen Duncaen merged commit a4fd4bb into void-linux:master Aug 9, 2023
8 checks passed
@cinerea0 cinerea0 deleted the gnucash branch August 10, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants