Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evince: update to 44.1 #43428

Merged
merged 1 commit into from
Jun 4, 2023
Merged

evince: update to 44.1 #43428

merged 1 commit into from
Jun 4, 2023

Conversation

pascal-huber
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl (crossbuild)
    • armv7l (crossbuild)
    • aarch64 (crossbuild)

Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove -Dnautilus=false from configure_args (it's now the default), and add -Dsystemduserunitdir=no (we don't want the systemd service files).

Otherwise, this looks good to me, and I tested it without issues.

srcpkgs/evince/template Show resolved Hide resolved
@triallax
Copy link
Contributor

By the way, you don't really have to do these cross-builds locally, since that's done in the CI in this case.

@paper42
Copy link
Member

paper42 commented Apr 13, 2023

We actually do want the systemd service files for documentation purposes, leave them there

@pascal-huber
Copy link
Contributor Author

By the way, you don't really have to do these cross-builds locally, since that's done in the CI in this case.

I was wondering about that - though I usually run them anyways as my computer is faster than CI.

@pascal-huber
Copy link
Contributor Author

pascal-huber commented Apr 13, 2023

Remove -Dnautilus=false from configure_args (it's now the default), and add -Dsystemduserunitdir=no (we don't want the systemd service files).

Otherwise, this looks good to me, and I tested it without issues.

I didn't add -Dsystemduserunitdir=no as @paper42 suggested.

@triallax
Copy link
Contributor

@paper42 thanks for the heads-up, I thought it was simply an oversight.

@triallax
Copy link
Contributor

Tested this and it's working fine, so it should be good to go IMO (unless you've got some changes to suggest @paper42?).

@paper42 paper42 merged commit a246592 into void-linux:master Jun 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants