-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evince: update to 44.1 #43428
evince: update to 44.1 #43428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove -Dnautilus=false
from configure_args
(it's now the default), and add -Dsystemduserunitdir=no
(we don't want the systemd service files).
Otherwise, this looks good to me, and I tested it without issues.
By the way, you don't really have to do these cross-builds locally, since that's done in the CI in this case. |
We actually do want the systemd service files for documentation purposes, leave them there |
I was wondering about that - though I usually run them anyways as my computer is faster than CI. |
I didn't add |
@paper42 thanks for the heads-up, I thought it was simply an oversight. |
Tested this and it's working fine, so it should be good to go IMO (unless you've got some changes to suggest @paper42?). |
Testing the changes
Local build testing