Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: flutter-3.7.11 #43438

Closed
wants to merge 1 commit into from
Closed

New package: flutter-3.7.11 #43438

wants to merge 1 commit into from

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Apr 14, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

as per #12749

Currently, it's still required to run chmod -R {username}:{username} /opt/flutter in order for flutter to work properly, I'd be happy to get an advice how to handle this inside the template.

@classabbyamp classabbyamp added the new-package This PR adds a new package label Apr 14, 2023
@Chocimier
Copy link
Member

chown {username}

Void is multi-user OS, so if /opt/ need to be owned to be useful, this not packagable.

@triallax
Copy link
Contributor

Would this fit in better as a restricted package? It essentially just redistributes the Flutter tarball.

@paper42
Copy link
Member

paper42 commented Apr 14, 2023

Would this fit in better as a restricted package? It essentially just redistributes the Flutter tarball.

I think it should be nonfree because we are not building from source. Afaik restricted is usually used for packages we can not distribute, is it this case?

Either way, building from source would be much better, we could build for multiple architectures, modify the source when needed and remove the nonfree restriction. This way it's equivalent to 2 commands - curl and tar xf

@Bnyro
Copy link
Contributor Author

Bnyro commented Apr 16, 2023

Either way, building from source would be much better, we could build for multiple architectures, modify the source when needed and remove the nonfree restriction. This way it's equivalent to 2 commands - curl and tar xf

Yes, I agree on that. I've been looking into the documentation on how to build flutter from source, however I doubt I'll be able to get that working given my few experience on building and packaging. I assume the best thing would be to close this PR and wait for somebody else to take the efforts to build it from source?

@triallax
Copy link
Contributor

I think it should be nonfree because we are not building from source. Afaik restricted is usually used for packages we can not distribute, is it this case?

Yeah, I didn't consider that, I guess this might better fit in in nonfree.

Either way, building from source would be much better, we could build for multiple architectures, modify the source when needed and remove the nonfree restriction. This way it's equivalent to 2 commands - curl and tar xf

I agree, but this is the best we can do until somebody comes up with a template to build Flutter from source.

@triallax
Copy link
Contributor

An update, somebody pointed me to this recently:

There seems to be some work over at Alpine Linux to package Flutter from source: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/44347

Predictably, it doesn't look trivial at all.

Originally posted by @mhmdanas in #12749 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants