Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: update to 115.0 #43607

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Conversation

pascal-huber
Copy link
Contributor

@pascal-huber pascal-huber commented Apr 25, 2023

[ci skip]

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
  • x86_64
  • armv7l (crossbuild)
  • aarch64 (crossbuild)
  • i686 (native)
  • x86_64-musl (native)
  • armv6l-musl (not supported)
  • aarch64-musl

Notes

  • Fixed MOZILLA_SITE
  • The UI seems a bit buggy with switching to calendars

@pascal-huber
Copy link
Contributor Author

added thunderbird-i18n (forgot to commit)

@pascal-huber
Copy link
Contributor Author

updated to 102.11.0

@pascal-huber pascal-huber changed the title thunderbird: update to 102.10.1 thunderbird: update to 102.11.0 May 12, 2023
@pascal-huber
Copy link
Contributor Author

updated to 102.12.0

@pascal-huber pascal-huber changed the title thunderbird: update to 102.11.0 thunderbird: update to 102.12.0 Jun 9, 2023
@pascal-huber
Copy link
Contributor Author

crossbuild fails for i686

@Chocimier
Copy link
Member

For i686 we only care about native build in i686 masterdir.

@pascal-huber
Copy link
Contributor Author

For i686 we only care about native build in i686 masterdir.

Thanks, unfortunately it also fails for the native build. I will have another look at it in the next days.

@ghost
Copy link

ghost commented Jul 14, 2023

i imagine thunderbird is going to stay in void packages, so it would make sense to update straight to 115.0 now that it's officially released and distributed

@pascal-huber
Copy link
Contributor Author

i imagine thunderbird is going to stay in void packages, so it would make sense to update straight to 115.0 now that it's officially released and distributed

Agree, more importantly it should also compile on i686. I haven't had much time recently because of my new job. I might find some time to rebase, update and have another go at it tomorrow.

@pascal-huber pascal-huber changed the title thunderbird: update to 102.12.0 thunderbird: update to 115.0 Jul 15, 2023
@pascal-huber
Copy link
Contributor Author

pascal-huber commented Jul 15, 2023

Updated to 115.0 (and unchecked the "Local build testing" boxes)

@pascal-huber
Copy link
Contributor Author

pascal-huber commented Jul 15, 2023

Added libotr runtime dependency. The UI seems a bit buggy, It won't show one of my calendars and sometimes it doesn't show the main menu to switch between emails and calendars.

Some of the errors:

[ImapModuleLoader] Using nsImapService.cpp
JavaScript error: resource:///modules/CalStartupService.jsm, line 18: uncaught exception: ParserError: invalid line (no token ";" or ":") "Europe/Zurich[2023c]"
JavaScript error: resource:///modules/CalStartupService.jsm, line 18: NS_ERROR_XPC_JS_THREW_JS_OBJECT: ParserError: invalid line (no token ";" or ":") "Europe/Zurich[2023c]"'ParserError: invalid line (no token ";" or ":") "Europe/Zurich[2023c]"' when calling method: [calIStartupService::startup]
console.debug: "Found 0 public keys and 0 secret keys (0 protected, 0 unprotected)"
console.warn: services.settings: Failed to load last_modified.json: TypeError: NetworkError when attempting to fetch resource.
console.error: Calendar:
  Can't create calendar for <some-id> (storage, moz-storage-calendar://): TypeError: right-hand side of 'in' should be an object, got undefined
console.error: Calendar:
  Message: TypeError: zone is null
  Stack:
    convertToZone@resource:///modules/calendar/Ical.jsm:5588:26
CalDateTime.prototype.getInTimezone<@resource:///modules/CalDateTime.jsm:141:45
unwrapSetter@resource:///modules/calendar/Ical.jsm:29:22
unwrap/<@resource:///modules/calendar/Ical.jsm:25:48
now@resource:///modules/calendar/utils/calDateTimeUtils.jsm:62:17
getStartDate@chrome://calendar/content/calendar-invitations-manager.js:347:24
updateStartDate@chrome://calendar/content/calendar-invitations-manager.js:366:30
getInvitations@chrome://calendar/content/calendar-invitations-manager.js:172:10
_doInvitationsUpdate@chrome://calendar/content/calendar-invitations-manager.js:122:52
scheduleInvitationsUpdate/this.mTimer<@chrome://calendar/content/calendar-invitations-manager.js:115:18

JavaScript error: resource:///modules/calendar/Ical.jsm, line 5588: TypeError: zone is null
console.debug: "Trying to load /usr/lib/thunderbird/libotr.so"
console.debug: "Trying to load libotr.so from system's standard library locations"
console.debug: "Trying to load libotr.so.5 from system's standard library locations"
console.debug: "Successfully loaded OTR library libotr.so.5 from system's standard library locations"
JavaScript error: resource:///modules/CalCalendarManager.jsm, line 444: TypeError: right-hand side of 'in' should be an object, got undefined
JavaScript error: chrome://calendar/content/calendar-creation.js, line 646: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "right-hand side of 'in' should be an object, got undefined" {file: "resource:///modules/CalCalendarManager.jsm" line: 444}]'[JavaScript Error: "right-hand side of 'in' should be an object, got undefined" {file: "resource:///modules/CalCalendarManager.jsm" line: 444}]' when calling method: [calICalendarManager::registerCalendar]

EDIT: everything seems fine with TZ='' thunderbird

@classabbyamp
Copy link
Member

probably relevant: https://lore.kernel.org/distributions/075a20b1-869b-78f3-9ace-e106a4d43ac4@linuxlounge.net/T/#u

@pascal-huber
Copy link
Contributor Author

@classabbyamp
Copy link
Member

rebased and tested the icu patch on x86_64-glibc. works for me

@pascal-huber
Copy link
Contributor Author

rebased and tested the icu patch on x86_64-glibc. works for me

thanks. It also works for me on x86_64-glibc. I noticed that the icu tests fail for me, but also on master, haven't inspected any further.

@classabbyamp classabbyamp merged commit b33e3c3 into void-linux:master Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants