Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: a4-0.2.1 #43734

Merged
merged 1 commit into from
Jun 22, 2023
Merged

New package: a4-0.2.1 #43734

merged 1 commit into from
Jun 22, 2023

Conversation

littlewing7
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-musl)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv7l-musl
    • armv6l-musl

@classabbyamp classabbyamp added the new-package This PR adds a new package label May 3, 2023
abenson
abenson reviewed May 4, 2023
View reviewed changes
srcpkgs/a4/template Outdated Show resolved Hide resolved
@littlewing7 littlewing7 force-pushed the a4-terminal.0.2.1 branch 2 times, most recently from d3670dc to fa33a87 Compare May 8, 2023 08:49
@littlewing7
Copy link
Contributor Author

I apologize, for some reasons I don't remove all the commented lines.

now should be ok!

many thanks for you patience!!
Max

@littlewing7 littlewing7 requested a review from abenson May 9, 2023 21:44
@littlewing7
Copy link
Contributor Author

Hi Guys,

this package doesn't break any other packages.
There are any particular reason preventing this package to be merged?
Can I help ?

Many thanks for your kindly reply.

Max

Duncaen
Duncaen reviewed May 19, 2023
View reviewed changes
srcpkgs/a4/template Outdated Show resolved Hide resolved
Duncaen
Duncaen reviewed May 19, 2023
View reviewed changes
srcpkgs/a4/template Outdated Show resolved Hide resolved
@littlewing7
Copy link
Contributor Author

Hi Duncan,

can help me how to correctly define the template to obtain the right compilation of this new package without breaking the common/shlibs, and contemporary satisfy the requirements of the original software: https://github.com/rpmohn/a4 (inside the readme I found this requirements).

before submitting this new package I already update the void templates for this required packages with this PRs:
(#43532)
(#43658)

Many thanks

Massimo

Duncaen
Duncaen reviewed Jun 19, 2023
View reviewed changes
srcpkgs/a4/template Outdated Show resolved Hide resolved
abenson
abenson reviewed Jun 20, 2023
View reviewed changes
srcpkgs/a4/template Outdated
revision=1
build_style=gnu-makefile
makedepends="libvterm-devel libtickit-devel"
short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
short_desc="Dynamic terminal window manager, partial rewrite of dvtm"

@littlewing7
Copy link
Contributor Author

Hi guys,

  1. is this template ok now ?
  2. what is needed now to be merged?

Many thanks
Max

Duncaen
Duncaen reviewed Jun 22, 2023
View reviewed changes
srcpkgs/a4/template Outdated
revision=1
build_style=gnu-makefile
makedepends="libvterm-devel libtickit-devel"
short_desc="Dynamic terminal window manager, partial rewrite of dvtm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would match the upstream short description:

Dynamic terminal manager and multiplexer

@littlewing7
Copy link
Contributor Author

Done

Max

@Duncaen Duncaen merged commit 52d1fa5 into void-linux:master Jun 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abenson abenson abenson left review comments

@Duncaen Duncaen Duncaen left review comments

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@littlewing7 @abenson @Duncaen @classabbyamp