New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-edit: update to 0.12.0. #44104

Closed

icp1994 wants to merge 1 commit into void-linux:master from icp1994:cargo-edit

Contributor

icp1994 commented May 26, 2023

Testing the changes

I tested the changes in this PR: YES

Local build testing

I built this PR locally for my native architecture: x86_64

Member

classabbyamp commented Jun 9, 2023 •

edited

Loading

what's the different between cargo's cargo add and cargo-edit's cargo add?


          cargo-edit: update to 0.12.0.

6f65311

icp1994 force-pushed the cargo-edit branch from 48e1712 to 6f65311 Compare

June 9, 2023 06:45

Contributor Author

icp1994 commented Jun 9, 2023

Nothing, was merged in cargo long time ago.

Member

classabbyamp commented Jun 9, 2023

it's no longer linking to libgit2: https://github.com/void-linux/void-packages/actions/runs/5219079314/jobs/9420509876?pr=44104#step:9:51

Contributor Author

icp1994 commented Jun 9, 2023

No idea why it's building the vendored code. It worked last time https://github.com/void-linux/void-packages/actions/runs/5039350583/jobs/9037435880?pr=44020#step:7:1071

I wish they would just merge rust-lang/git2-rs#939 - would make life easier.

Member

classabbyamp commented Jun 10, 2023

integrated into #43435

classabbyamp closed this

icp1994 deleted the cargo-edit branch

June 10, 2023 14:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment