yt-dlp: add depends from pip3 check #44185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly does this achieve? I don't see any failing tests right now without these dependencies. We don't use pip3 check, we use pytest. |
|
they may be not covered by tests, but see https://github.com/yt-dlp/yt-dlp/blob/master/requirements.txt |
|
IMO, Either we should add those dependency, or we need to modify requirements.txt to remove those requirements. |
|
related: #42661 |
|
According to upstream (linked): "Unless there is reason to, it is recommended to install the dependencies too" and "we want default installs (from pip or source) to have these dependencies included". |
|
time to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from running
pip3 checkon my systemcc maintainer @paper42