-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: HeroicGamesLauncher-2.8.0 #44207
New package: HeroicGamesLauncher-2.8.0 #44207
Conversation
11819c2
to
f94f044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and tested successfully with Node 18.16.
8634f3d
to
c9045cf
Compare
Changed from using the pre-compiled electron binaries to using the binaries from the package. Also made it use packages for legendary and gogdl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be split into two commits, one per new package.
c9045cf
to
44901ee
Compare
44901ee
to
5499420
Compare
patch for 2.9.0: diff --git a/srcpkgs/HeroicGamesLauncher/template b/srcpkgs/HeroicGamesLauncher/template
index 6bca53f7ca..e2f80bdfed 100644
--- a/srcpkgs/HeroicGamesLauncher/template
+++ b/srcpkgs/HeroicGamesLauncher/template
@@ -1,6 +1,6 @@
# Template file for 'HeroicGamesLauncher'
pkgname=HeroicGamesLauncher
-version=2.8.0
+version=2.9.0
revision=1
archs="x86_64*"
_electron_version=24
@@ -12,9 +12,10 @@ maintainer="sirkhancision <jsantiago12tone@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
-checksum=59f068d6ba7e6c9c5d3c08f06b4cee23f07452777b9edb8baa61895fa9f40320
+checksum=b0b0e61f5f20af09527fc53b3493ede170fc7df2a148bcce7b4d83b441b8203b
nopie_files="/usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/gogdl
-/usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/legendary"
+ /usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/legendary
+ /usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/nile"
pre_build() {
jq 'del(.scripts.prepare)' package.json >tmp.json |
2.9.0 doesn't seem to launch, not really sure why |
80368d1
to
5499420
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing