Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: HeroicGamesLauncher-2.8.0 #44207

Closed

Conversation

sirkhancision
Copy link
Contributor

@sirkhancision sirkhancision commented Jun 1, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

@classabbyamp classabbyamp added electron 🤮 Electron package request new-package This PR adds a new package labels Jun 1, 2023
Copy link
Contributor

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested successfully with Node 18.16.

@sirkhancision sirkhancision force-pushed the HeroicGamesLauncher branch 3 times, most recently from 8634f3d to c9045cf Compare June 27, 2023 21:18
@sirkhancision
Copy link
Contributor Author

Changed from using the pre-compiled electron binaries to using the binaries from the package. Also made it use packages for legendary and gogdl.

Copy link
Member

@Duncaen Duncaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be split into two commits, one per new package.

@Bnyro
Copy link
Contributor

Bnyro commented Jul 26, 2023

patch for 2.9.0:

diff --git a/srcpkgs/HeroicGamesLauncher/template b/srcpkgs/HeroicGamesLauncher/template
index 6bca53f7ca..e2f80bdfed 100644
--- a/srcpkgs/HeroicGamesLauncher/template
+++ b/srcpkgs/HeroicGamesLauncher/template
@@ -1,6 +1,6 @@
 # Template file for 'HeroicGamesLauncher'
 pkgname=HeroicGamesLauncher
-version=2.8.0
+version=2.9.0
 revision=1
 archs="x86_64*"
 _electron_version=24
@@ -12,9 +12,10 @@ maintainer="sirkhancision <jsantiago12tone@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
 distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
-checksum=59f068d6ba7e6c9c5d3c08f06b4cee23f07452777b9edb8baa61895fa9f40320
+checksum=b0b0e61f5f20af09527fc53b3493ede170fc7df2a148bcce7b4d83b441b8203b
 nopie_files="/usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/gogdl
-/usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/legendary"
+	/usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/legendary
+	/usr/lib/HeroicGamesLauncher/resources/app.asar.unpacked/build/bin/linux/nile"
 
 pre_build() {
 	jq 'del(.scripts.prepare)' package.json >tmp.json

@Bnyro
Copy link
Contributor

Bnyro commented Jul 26, 2023

2.9.0 doesn't seem to launch, not really sure why

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Oct 25, 2023
@github-actions github-actions bot closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron 🤮 Electron package request new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants