dbeaver: update to 23.1.0. #44299
Merged
dbeaver: update to 23.1.0. #44299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hervyqa
reviewed
Jul 26, 2023
| @@ -1,9 +1,8 @@ | |||
| [Desktop Entry] | |||
| Name=DBeaver | |||
| Comment=SQL Integrated Development Environment | |||
| Icon=dbeaver | |||
| Icon=/usr/lib/dbeaver/icon.xpm | |||
There was a problem hiding this comment.
@ar-jan why did you change the icon path?
this will break other icon like papirus-icons which already provide default icon from the theme.
There was a problem hiding this comment.
most linux distributions use Icon=dbeaver
reference:
- nixos: https://github.com/NixOS/nixpkgs/blob/b80a9abe3f9bb1fd059b007bd16ee11f6adf1663/pkgs/applications/misc/dbeaver/default.nix#L63
- archlinux: https://gitlab.archlinux.org/archlinux/packaging/packages/dbeaver/-/blob/main/io.dbeaver.DBeaver.desktop#L11
- solus: https://dev.getsol.us/source/dbeaver/browse/master/files/DBeaver.desktop$6
There was a problem hiding this comment.
Icon=dbeaver never worked for me so I had no icon for dbeaver (I use KDE5 Plasma). I wasn't aware this change would break other configs, how does papirus-icons work?
There was a problem hiding this comment.
didn't work, papirus-icon-theme couldn't read it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes