xbps-src: new vopt_feature helper #44663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
I didn't check this against every template where the pattern appears, but it works in the test cases I tried.
This helper function reduces boilerplate for Meson's "feature" build options. Right now these are handled using the pattern
-D<property>=$(vopt_if <option> enabled disabled)
, which occurs 78 times in our templates.Note that this does not allow you to set the property to "auto", but I can't think of any situation where that would be desirable.