Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: fix update-check #44760

Closed
wants to merge 1 commit into from
Closed

zlib: fix update-check #44760

wants to merge 1 commit into from

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Jul 1, 2023

Testing the changes

  • I tested the changes in this PR: YES

@Chocimier
Copy link
Member

old pattern just works, why the change?

@Bnyro
Copy link
Contributor Author

Bnyro commented Jul 1, 2023

It doesn't work, it outputs there word be a 1213 release.

@Bnyro
Copy link
Contributor Author

Bnyro commented Jul 1, 2023

Because it doesn't handle dots properly.

@Chocimier
Copy link
Member

?

./xbps-src update-check zlib      
using zlib/update overrides
fetching https://www.zlib.net and scanning with <B> zlib \K.+?(?=</B>)
fetching https://www.zlib.net/fossils/ and scanning with <B> zlib \K.+?(?=</B>)
found version 1.2.13

@Bnyro
Copy link
Contributor Author

Bnyro commented Jul 2, 2023

Oh, I just noticed the issue is when checking for updates for zlib-32bit, zlib itself works properly:

$ ./xbps-src update-check zlib-32bit
zlib-1.2.13 -> zlib-1213

But I don't really have a clue why it works properly for zlib in the meanwhile, don't they use the same template?

The changes in this PR don't have an impact on that, still claims to have a new 1213 release available.

@Bnyro Bnyro marked this pull request as draft July 2, 2023 08:06
@Bnyro Bnyro closed this Jul 2, 2023
@Bnyro Bnyro deleted the zlib branch July 2, 2023 13:34
@Chocimier
Copy link
Member

update-check on -32bit packages is not an useful operation, as they are made from plain i686 build.
Going to details, this didn't work because xbps-src tries to read non-existent srcpkgs/zlib-32bit/update here.

@Bnyro
Copy link
Contributor Author

Bnyro commented Jul 3, 2023

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants